Re: [Fwd: [BUG] sata_via doesn't detect anymore my disks (broken between rc1 and rc3)]

[Tejun Heo <htejun@gmail.com>]

Thierry Vignaud wrote:
> Tejun Heo <htejun@gmail.com> writes:
> 
>>>> none of both these patches worked :-(
>>> The second didn't work?  But you said the following one liner worked.
>>>
>>> --- drivers/ata/sata_via.c.tv6	2006-08-20 16:37:41.000000000 +0200
>>> +++ drivers/ata/sata_via.c	2006-08-20 17:20:23.000000000 +0200
>>> @@ -244,7 +244,7 @@
>>>
>>>  static void vt6421_error_handler(struct ata_port *ap)
>>>  {
>>> -	return ata_bmdma_drive_eh(ap, ata_std_prereset, NULL,
>>> +	return ata_bmdma_drive_eh(ap, vt6420_prereset, ata_std_softreset,
>>>  				  sata_std_hardreset, ata_std_postreset);
>>>  }
>>>
>>> The second patch is essentially identical to what you did the one liner. 
>>>  Can you please check it once more?  I'll prepare old-sequence 
>>> hardreset in the meantime.
>> Okay, here's the old-sequence hardreset patch.  This should have the
>> highest chance of working.  This patch should be applied on top of the
>> vt6420 patch.
> 
> On top of which patch?
> I just tried to apply it on top of:
> - your last week patch
> - your two patches of this week
> 
> and it does *not* apply on top of anyone...

Arghh... Sorry.  I sent the wrong version.  This patch is against 
#upstream while I should have sent the one against #upstream-fixes.

> Couldn't you either check first your patch or (better) just send a
> patch against vanilla 2.6.18-rc4-mm2?

I've attached whole sata_via.c to the other mail.  I think that should 
do the trick.

thanks.

-- 
tejun