Re: [PATCH 9/20] libata: reimplement LLD init_one()'s using new init helpers

[Tejun Heo <htejun@gmail.com>]

Helloooo,

Jeff Garzik wrote:
> Unfortunately, while this patch seems correct, it is also difficult to 
> review, and I'm thinking it reflects that another approach may need to 
> be considered.
> 
> Usually the drivers and API are often change in small chunks, whereas 
> this patchset is more along the lines of
> 1) add new helpers
> 2) update everything to use new helpers
> 3) delete old helpers
> 
> The previous approach was closer to
> * small update to API & drivers
> * small update to API & drivers
> * small update to API & drivers
> ...
> 
> I recognize that we are changing the LLDD init model, but I bet if you 
> think really hard, you could come up with a less-drastic transition path.

This patchset has been one of the most painful to carry around due to 
dependencies on everything and the wide range of changes.  I agree that 
there can be a better way to split this patch if I think *really* hard, 
but was kind of hoping I could avoid that.  :-)

I'll try to reshuffle the whole set as you suggested but I can't say for 
sure.  Please note that lots of previous EH changes were done this way - 
implement new framework while leaving old one alone, convert LLDs, kill 
old framework.  I have to admit that this patchset is more drastic tho.

Thanks.

-- 
tejun