From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] ata-piix: kerneldoc-error-on-ata_piixc.patch 2nd try Date: Mon, 25 Sep 2006 16:13:52 -0400 Message-ID: <45183880.40003@pobox.com> References: <451826BE.2040201@nachtwindheim.de> <4518305C.3090906@pobox.com> <20060925131151.4f73612c.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:1744 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751016AbWIYUOA (ORCPT ); Mon, 25 Sep 2006 16:14:00 -0400 In-Reply-To: <20060925131151.4f73612c.rdunlap@xenotime.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Randy Dunlap Cc: Henne , Andrew Morton , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Randy Dunlap wrote: > I agree with all of these except #4. Maybe you can reconcile your > preference with that in Documentation/SubmittingPatches, which > contains: > > > The canonical patch message body contains the following: > > - A "from" line specifying the patch author. > > > A patch submitter should not need to know the patch receiver's > personal preferences and vary patches based on those. It's not a personal preference. It's all based on git-applymbox, pretty much. The SubmittingPatches doc should be updated to clarify that a From line is not needed in the email body, if it is the same as the From line in the RFC822 header. Jeff