From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: castet.matthieu@free.fr, alan@lxorguk.ukuu.org.uk,
linux-ide@vger.kernel.org, akpm@osdl.org
Subject: Re: [RFT PATCH] libata: implement ATA_FLAG_SETXFER_POLLING and use it in pata_via
Date: Fri, 29 Sep 2006 09:28:06 +0900 [thread overview]
Message-ID: <451C6896.9060207@gmail.com> (raw)
In-Reply-To: <451BB121.9020702@garzik.org>
Jeff Garzik wrote:
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 753b015..c71d896 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4082,7 +4082,8 @@ int ata_hsm_move(struct ata_port *ap, st
>>
>> fsm_start:
>> DPRINTK("ata%u: protocol %d task_state %d (dev_stat 0x%X)\n",
>> - ap->id, qc->tf.protocol, ap->hsm_task_state, status);
>> + ap->id, qc->tf.protocol, ap->hsm_task_state, status,
>> + qc->tf.flags & ATA_TFLAG_POLLING);
>
> You need to update the format string too...
Ah... That's left over from debugging session. I'll kill it.
Thanks.
--
tejun
next prev parent reply other threads:[~2006-09-29 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 11:11 [RFT PATCH] libata: implement ATA_FLAG_SETXFER_POLLING and use it in pata_via Tejun Heo
2006-09-28 11:25 ` Jeff Garzik
2006-09-29 0:28 ` Tejun Heo [this message]
2006-09-28 11:51 ` Alan Cox
2006-10-10 18:45 ` matthieu castet
2006-10-10 18:47 ` matthieu castet
2006-10-10 22:09 ` Tejun Heo
2006-11-13 20:29 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451C6896.9060207@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=castet.matthieu@free.fr \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).