From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, fajunchen@gmail.com
Subject: Re: [PATCH] libata: make user scan wait for scan to complete
Date: Thu, 05 Oct 2006 07:22:40 -0400 [thread overview]
Message-ID: <4524EB00.9040309@pobox.com> (raw)
In-Reply-To: <20060930090717.GO25800@htj.dyndns.org>
Tejun Heo wrote:
> Make user scan wait for scan to complete. This way user can wait for
> warm plug request to complete and is prevented from causing EH event
> storm by repetitively issuing scan request while EH is in progress.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Fajun Chen <fajunchen@gmail.com>
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 3986ec8..e1fe832 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -3138,10 +3138,12 @@ static int ata_scsi_user_scan(struct Scs
> rc = -EINVAL;
> }
>
> - if (rc == 0)
> + if (rc == 0) {
> ata_port_schedule_eh(ap);
> -
> - spin_unlock_irqrestore(ap->lock, flags);
> + spin_unlock_irqrestore(ap->lock, flags);
> + ata_port_wait_eh(ap);
> + } else
> + spin_unlock_irqrestore(ap->lock, flags);
Given that we are now 2.6.19-rc1, would you say this applies to
#upstream-fixes or #upstream?
I'm OK with it either way.
Jeff
next prev parent reply other threads:[~2006-10-05 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 9:07 [PATCH] libata: make user scan wait for scan to complete Tejun Heo
2006-10-05 11:22 ` Jeff Garzik [this message]
2006-10-08 4:17 ` Tejun Heo
2006-11-01 5:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4524EB00.9040309@pobox.com \
--to=jgarzik@pobox.com \
--cc=fajunchen@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).