From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, robbat2@gentoo.org
Subject: Re: [PATCH 1/2] ahci: preserve PORTS_IMPL over host resets
Date: Thu, 05 Oct 2006 07:27:05 -0400 [thread overview]
Message-ID: <4524EC09.2070608@pobox.com> (raw)
In-Reply-To: <20060930122121.GR25800@htj.dyndns.org>
Tejun Heo wrote:
> Instead of writing 0xf blindly, preserve the content of write-once
> PORTS_IMPL register over host resets.
>
> This patch is taken from Jeff Garzik's AHCI init update patch.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Jeff Garzik <jgarzik@pobox.com>
One reason why I didn't go ahead and apply this is for
uninitalized-by-BIOS cases that are the reason I originally hardcoded a
0xf value into the register.
This patch is OK, iff we also include a test to see if impl_save==0
prior to global reset. If that is the case, we should hardcode 0xf or
(1<<n_ports)-1
Jeff
next prev parent reply other threads:[~2006-10-05 11:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 12:21 [PATCH 1/2] ahci: preserve PORTS_IMPL over host resets Tejun Heo
2006-09-30 12:22 ` [PATCH 2/2] [PATCH] ahci: honor PORTS_IMPL on ICH8s Tejun Heo
2006-09-30 16:13 ` Robin H. Johnson
2006-10-05 11:25 ` Jeff Garzik
2006-10-05 15:12 ` Tejun Heo
2006-10-05 11:27 ` Jeff Garzik [this message]
2006-10-05 15:02 ` [PATCH 1/2] ahci: preserve PORTS_IMPL over host resets Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4524EC09.2070608@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=robbat2@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).