Re: [RFT PATCH] libata: implement ATA_FLAG_SETXFER_POLLING and use it in pata_via

[Tejun Heo <htejun@gmail.com>]

matthieu castet wrote:
> matthieu castet wrote:
>> Hi,
>>
>> Sorry for the delay.
>>
>> Tejun Heo wrote:
>>
>>> This patch implements ATA_FLAG_SETXFER_POLLING and use in pata_via.
>>> If this flag is set, transfer mode setting performed by polling not by
>>> interrupt.  This should help those controllers which raise interrupt
>>> before the command is actually complete on SETXFER.
>>>
>>> Rationale for this approach.
>>>
>>> * uses existing facility and relatively simple
>>> * no busy sleep in the interrupt handler
>>> * updating drivers is easy
>>>
>>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>> ---
>>>
>>> Matthieu Castet, can you please test this patch?  It's against
>>> libata-dev#upstream, but -mm might work too.  If you want a patch
>>> against -mm, just let me know.
>>
>>
>> With the attached patch against 19-rc1-mm1 (I had to remove pata irq 
>> handler), it seems to work (see the attached log).
>>                           * polling IDENTIFY */
>> +    ATA_FLAG_SETXFER_POLLING= (1 << 14), /* use polling for SETXFER */
>>  
> opps i forgot to change ATA_FLAG_SETXFER_POLLING to 
> ATA_FLAG_SETXFER_POLLING (1<<15).
> 
> I suppose I need to retest that ?

Yes, you probably need to.  Both features must have kicked in.

Thanks.

-- 
tejun