From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [RFT PATCH] libata: implement ATA_FLAG_SETXFER_POLLING and use it in pata_via Date: Wed, 11 Oct 2006 07:09:29 +0900 Message-ID: <452C1A19.6010607@gmail.com> References: <20060928111151.GN25800@htj.dyndns.org> <452BEA3D.4020204@free.fr> <452BEAB7.9010901@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from nz-out-0102.google.com ([64.233.162.202]:61931 "EHLO nz-out-0102.google.com") by vger.kernel.org with ESMTP id S1030568AbWJJWJg (ORCPT ); Tue, 10 Oct 2006 18:09:36 -0400 Received: by nz-out-0102.google.com with SMTP id n1so5726nzf for ; Tue, 10 Oct 2006 15:09:35 -0700 (PDT) In-Reply-To: <452BEAB7.9010901@free.fr> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: matthieu castet Cc: alan@lxorguk.ukuu.org.uk, jeff@garzik.org, linux-ide@vger.kernel.org, akpm@osdl.org matthieu castet wrote: > matthieu castet wrote: >> Hi, >> >> Sorry for the delay. >> >> Tejun Heo wrote: >> >>> This patch implements ATA_FLAG_SETXFER_POLLING and use in pata_via. >>> If this flag is set, transfer mode setting performed by polling not by >>> interrupt. This should help those controllers which raise interrupt >>> before the command is actually complete on SETXFER. >>> >>> Rationale for this approach. >>> >>> * uses existing facility and relatively simple >>> * no busy sleep in the interrupt handler >>> * updating drivers is easy >>> >>> Signed-off-by: Tejun Heo >>> --- >>> >>> Matthieu Castet, can you please test this patch? It's against >>> libata-dev#upstream, but -mm might work too. If you want a patch >>> against -mm, just let me know. >> >> >> With the attached patch against 19-rc1-mm1 (I had to remove pata irq >> handler), it seems to work (see the attached log). >> * polling IDENTIFY */ >> + ATA_FLAG_SETXFER_POLLING= (1 << 14), /* use polling for SETXFER */ >> > opps i forgot to change ATA_FLAG_SETXFER_POLLING to > ATA_FLAG_SETXFER_POLLING (1<<15). > > I suppose I need to retest that ? Yes, you probably need to. Both features must have kicked in. Thanks. -- tejun