From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, aalderd.boac@wanadoo.nl,
linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] ahci updates regarding vt8251 support, take #2
Date: Sat, 21 Oct 2006 15:23:58 -0400 [thread overview]
Message-ID: <453A73CE.60205@pobox.com> (raw)
In-Reply-To: <11609522031228-git-send-email-htejun@gmail.com>
Patchset looks OK to me, with a few notes:
1) might want to separate out this change and forward it to #upstream-fixes:
- ahci_tf_read(ap, &tf);
- if (tf.command & (ATA_BUSY | ATA_DRQ)) {
+ if (ahci_check_status(ap) & (ATA_BUSY | ATA_DRQ)) {
2) In general, it's a good idea to clear SError after twiddling with the
phy. Not just on vt8521.
3) Any positive test results yet?
next prev parent reply other threads:[~2006-10-21 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-15 22:43 [PATCHSET] ahci updates regarding vt8251 support, take #2 Tejun Heo
2006-10-15 22:43 ` [PATCH 3/3] [PATCH] ahci: update ahci-vt8251 reset sequence Tejun Heo
2006-10-15 22:43 ` [PATCH 1/3] [PATCH] libata: separate out and export sata_port_hardreset() Tejun Heo
2006-10-15 22:43 ` [PATCH 2/3] [PATCH] ahci: update softreset and kill AHCI_FLAG_RESET_NEEDS_CLO Tejun Heo
2006-10-18 4:45 ` [PATCHSET] ahci updates regarding vt8251 support, take #2 Aalderd Bouwman
2006-10-18 11:50 ` Tejun Heo
2006-10-18 17:02 ` Aalderd Bouwman
2006-10-21 19:23 ` Jeff Garzik [this message]
2006-10-23 2:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453A73CE.60205@pobox.com \
--to=jgarzik@pobox.com \
--cc=aalderd.boac@wanadoo.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).