From: Jeff Garzik <jgarzik@pobox.com>
To: Conke Hu <conke.hu@amd.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: AHCI should try to claim all AHCI controllers
Date: Wed, 01 Nov 2006 00:07:51 -0500 [thread overview]
Message-ID: <45482BA7.6070904@pobox.com> (raw)
In-Reply-To: <FFECF24D2A7F6D418B9511AF6F358602F2CE9E@shacnexch2.atitech.com>
Conke Hu wrote:
> Hi all,
> According to PCI 3.0 spec, ACHI's PCI class code is 0x010601,
> and I suggest the ahci driver had better try to claim all ahci
> controllers, pls see the following patch:
>
> diff -Nur linux-2.6.17/drivers/scsi/ahci.c
> linux-2.6.17-ahci/drivers/scsi/ahci.c
> --- linux-2.6.17/drivers/scsi/ahci.c 2006-06-18 09:49:35.000000000
> +0800
> +++ linux-2.6.17-ahci/drivers/scsi/ahci.c 2006-10-31
> 22:50:54.000000000 +0800
> @@ -296,6 +296,11 @@
> board_ahci }, /* ATI SB600 non-raid */
> { PCI_VENDOR_ID_ATI, 0x4381, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> board_ahci }, /* ATI SB600 raid */
> + /* Claim all AHCI controllers not listed above.
> + * According to PCI 3.0, AHCI's class code is 0x010601
> + */
> + { PCI_AND_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, 0x010601,
> 0xffffff,
> + board_ahci },
> { } /* terminate list */
> };
Since things have settled in this area, yes, this would probably be a
good thing to add.
For the benefit of others, some background: we should not be -removing-
any PCI IDs due to this, because quite often the PCI class code will be
RAID or something else, yet still be drive-able with this ahci driver.
Jeff
next prev parent reply other threads:[~2006-11-01 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 15:06 AHCI should try to claim all AHCI controllers Conke Hu
2006-11-01 5:07 ` Jeff Garzik [this message]
2006-11-01 5:22 ` Linus Torvalds
2006-11-01 5:35 ` Jeff Garzik
2006-11-01 12:23 ` Alan Cox
2006-11-01 14:37 ` Mark Lord
2006-11-01 5:11 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-11-01 13:39 Conke Hu
2006-11-02 13:15 ` Martin Waitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45482BA7.6070904@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=conke.hu@amd.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).