From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: nabiki@teleline.es, kaos@ocs.com.au, stevenm@umd.edu,
jfs@keytradebank.com, 0602@eq.cz, akpm@osdl.org,
alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/6] ata_piix: clean up port flags
Date: Wed, 01 Nov 2006 00:19:47 -0500 [thread overview]
Message-ID: <45482E73.70004@pobox.com> (raw)
In-Reply-To: <45482CC1.9090301@gmail.com>
Tejun Heo wrote:
> Jeff Garzik wrote:
>> Tejun Heo wrote:
>>> * move common flags into PIIX_PATA_FLAGS and PIIX_SATA_FLAGS
>>> * kill unnecessary ATA_FLAG_SRST
>>>
>>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>
>> AFAICS, SRST is quite necessary on PATA. What's going on? There
>> isn't much of any explanation for the SRST removal here :/
>
> Both reset flags ATA_FLAG_SATA_RESET and ATA_FLAG_SRST are used to tell
> old EH how to reset and probe the port. In new EH, those flags don't
> play any role. What method to use and in what sequence is upto
> ->error_handler() now. For PATA piix, it only implements SRST, so
> that's gonna be used. For SATA piix, ata_bmdma_drive_eh() always
> prefers SRST on boot probe.
>
> Once sata_promise/mv/.. are converted to new EH, the above two reset
> flags can be removed.
Ah, duh. I knew that, thanks for the clue-hammer :)
Jeff
next prev parent reply other threads:[~2006-11-01 5:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 6:46 [PATCHSET] libata: implement presence detection using polling IDENTIFY for ata_piix Tejun Heo
2006-09-30 6:46 ` [PATCH 2/6] libata: unexport ata_dev_revalidate() Tejun Heo
2006-09-30 6:46 ` [PATCH 3/6] libata: convert @post_reset to @flags in ata_dev_read_id() Tejun Heo
2006-11-01 5:36 ` Jeff Garzik
2006-09-30 6:46 ` [PATCH 1/6] ata_piix: clean up port flags Tejun Heo
2006-11-01 4:55 ` Jeff Garzik
2006-11-01 5:12 ` Tejun Heo
2006-11-01 5:19 ` Jeff Garzik [this message]
2006-11-01 5:35 ` Jeff Garzik
2006-09-30 6:46 ` [PATCH 5/6] ata_piix: apply device detection via polling IDENTIFY Tejun Heo
2006-09-30 6:46 ` [PATCH 6/6] ata_piix: strip now unneded MAP related stuff Tejun Heo
2006-09-30 6:46 ` [PATCH 4/6] libata: implement presence detection via polling IDENTIFY Tejun Heo
2006-09-30 8:59 ` [PATCHSET] libata: implement presence detection using polling IDENTIFY for ata_piix Alessandro Bono
2006-09-30 9:09 ` Alessandro Bono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45482E73.70004@pobox.com \
--to=jgarzik@pobox.com \
--cc=0602@eq.cz \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jfs@keytradebank.com \
--cc=kaos@ocs.com.au \
--cc=linux-ide@vger.kernel.org \
--cc=nabiki@teleline.es \
--cc=stevenm@umd.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).