* sata_via broken in 2.6.19rc4
@ 2006-11-07 22:36 Martin Devera
2006-11-08 13:32 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Martin Devera @ 2006-11-07 22:36 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide
Hi,
it seems there is typo in sata_via.c (see ATA_PFLAG_LOADING constant usage):
static int vt6420_prereset(struct ata_port *ap)
{
struct ata_eh_context *ehc = &ap->eh_context;
unsigned long timeout = jiffies + (HZ * 5);
u32 sstatus, scontrol;
int online;
/* don't do any SCR stuff if we're not loading */
if (!ATA_PFLAG_LOADING)
goto skip_scr;
also, It doesn't work on my 6420 hw. When I unplugged (and replugged) drive it
cycles forever like below. Any idea what is wrong ?
Nov 7 19:07:10 www1 kernel: [ 4774.536000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0
action 0x
2 frozen
Nov 7 19:07:10 www1 kernel: [ 4774.536000] ata1.00: (BMDMA stat 0x1)
Nov 7 19:07:10 www1 kernel: [ 4774.536000] ata1.00: tag 0 cmd 0xc8 Emask 0x4 stat 0x40 err
0x0 (tim
eout)
Nov 7 19:07:16 www1 kernel: [ 4779.636000] ata1: SATA link down 1.5 Gbps (SStatus 1
SControl 300)
Nov 7 19:07:16 www1 kernel: [ 4779.636000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:07:16 www1 kernel: [ 4779.640000] ata1: EH complete
Nov 7 19:07:16 www1 kernel: [ 4779.640000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:07:16 www1 last message repeated 2 times
Nov 7 19:07:46 www1 kernel: [ 4809.640000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0
action 0x
2 frozen
Nov 7 19:07:46 www1 kernel: [ 4809.640000] ata1.00: (BMDMA stat 0x1)
Nov 7 19:07:46 www1 kernel: [ 4809.640000] ata1.00: tag 0 cmd 0xc8 Emask 0x4 stat 0x40 err
0x0 (tim
eout)
Nov 7 19:07:51 www1 kernel: [ 4814.740000] ata1: SATA link down 1.5 Gbps (SStatus 1
SControl 300)
Nov 7 19:14:52 www1 kernel: [ 4814.740000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 kernel: [ 4814.744000] ata1: EH complete
Nov 7 19:14:52 www1 kernel: [ 4814.744000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 last message repeated 2 times
Nov 7 19:14:52 www1 kernel: [ 4844.744000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0
action 0x
2 frozen
Nov 7 19:14:52 www1 kernel: [ 4844.744000] ata1.00: (BMDMA stat 0x1)
Nov 7 19:14:52 www1 kernel: [ 4844.744000] ata1.00: tag 0 cmd 0xc8 Emask 0x4 stat 0x40 err
0x0 (tim
eout)
Nov 7 19:14:52 www1 kernel: [ 4849.844000] ata1: SATA link down 1.5 Gbps (SStatus 1
SControl 300)
Nov 7 19:14:52 www1 kernel: [ 4849.844000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 kernel: [ 4849.848000] ata1: EH complete
Nov 7 19:14:52 www1 kernel: [ 4849.848000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 last message repeated 2 times
Nov 7 19:14:52 www1 kernel: [ 4879.848000] ata1.00: limiting speed to UDMA/100
Nov 7 19:14:52 www1 kernel: [ 4879.848000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0
action 0x
2 frozen
Nov 7 19:14:52 www1 kernel: [ 4879.848000] ata1.00: (BMDMA stat 0x1)
Nov 7 19:14:52 www1 kernel: [ 4879.848000] ata1.00: tag 0 cmd 0xc8 Emask 0x4 stat 0x40 err
0x0 (tim
eout)
Nov 7 19:14:52 www1 kernel: [ 4884.948000] ata1: SATA link down 1.5 Gbps (SStatus 1
SControl 300)
Nov 7 19:14:52 www1 kernel: [ 4884.948000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 kernel: [ 4884.952000] ata1: EH complete
Nov 7 19:14:52 www1 kernel: [ 4884.952000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 last message repeated 2 times
Nov 7 19:14:52 www1 kernel: [ 4914.952000] ata1.00: limiting speed to UDMA/66
Nov 7 19:14:52 www1 kernel: [ 4914.952000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0
action 0x
2 frozen
Nov 7 19:14:52 www1 kernel: [ 4914.952000] ata1.00: (BMDMA stat 0x1)
Nov 7 19:14:52 www1 kernel: [ 4914.952000] ata1.00: tag 0 cmd 0xc8 Emask 0x4 stat 0x40 err
0x0 (tim
eout)
Nov 7 19:14:52 www1 kernel: [ 4920.052000] ata1: SATA link down 1.5 Gbps (SStatus 1
SControl 300)
Nov 7 19:14:52 www1 kernel: [ 4920.052000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 kernel: [ 4920.056000] ata1: EH complete
Nov 7 19:14:52 www1 kernel: [ 4920.056000] ATA: abnormal status 0xD0 on port 0xC007
Nov 7 19:14:52 www1 last message repeated 2 times
Nov 7 19:14:52 www1 kernel: [ 4950.056000] ata1.00: limiting speed to UDMA/44
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sata_via broken in 2.6.19rc4
2006-11-07 22:36 sata_via broken in 2.6.19rc4 Martin Devera
@ 2006-11-08 13:32 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-11-08 13:32 UTC (permalink / raw)
To: Martin Devera; +Cc: linux-ide
Martin Devera wrote:
> Hi,
>
> it seems there is typo in sata_via.c (see ATA_PFLAG_LOADING constant
> usage):
>
> static int vt6420_prereset(struct ata_port *ap)
> {
> struct ata_eh_context *ehc = &ap->eh_context;
> unsigned long timeout = jiffies + (HZ * 5);
> u32 sstatus, scontrol;
> int online;
>
> /* don't do any SCR stuff if we're not loading */
> if (!ATA_PFLAG_LOADING)
> goto skip_scr;
thanks for spotting this, fix pushed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-08 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-07 22:36 sata_via broken in 2.6.19rc4 Martin Devera
2006-11-08 13:32 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).