* Re: [PATCH 2/2] Workaround for SB600 SATA ODD issue
[not found] <20061103190004.9ED8DCBD48@localhost.localdomain>
@ 2006-11-08 13:30 ` Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2006-11-08 13:30 UTC (permalink / raw)
To: Luugi Marsan; +Cc: linux-kernel, linux-ide@vger.kernel.org
Luugi Marsan wrote:
> From: conke.hu@amd.com
>
> There was an ASIC bug in the SB600 SATA controller of low revision (<=13) and CD burning may hang (only SATA ODD has this issue, and SATA HDD works well). The patch provides a workaround for this issue.
>
> Signed-off-by: Luugi Marsan <luugi.marsan@amd.com>
ACK technical content, but it needs one revision: like someone else
(Alan or Tejun?) mentioned, this patch should be revised to use a
separate ata_port_operations for the affected chip(s).
Copy ahci_ops to sb600_ops, add your check-atapi-dma function without
the vendor/device ID check. Move the vendor/device check to the
pci_device_id table by creating a board_ahci_sb600 constant and
associated table data.
I agree with other posters that we should move the revision check to
more generic code, but such a move should not block this patch. The two
efforts can occur in parallel.
Jeff
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-08 13:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20061103190004.9ED8DCBD48@localhost.localdomain>
2006-11-08 13:30 ` [PATCH 2/2] Workaround for SB600 SATA ODD issue Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).