Re: [PATCH 1/1] libata: Convert from module_init to subsys_initcall

[Brian King <brking@us.ibm.com>]

Jeff,

Any chance of pushing this into 2.6.19? I've been had several
people hit this oops.

Thanks,

Brian


Brian King wrote:
> When building a monolithic kernel, the load order of drivers
> does not work for SAS libata users, resulting in driver load
> failures. Convert libata to use subsys_initcall instead of
> module_init, which ensures that libata gets loaded before
> any LLDD. This is the same thing that scsi core does
> to solve the problem. The load order problem was observed on
> ipr SAS adapters and should exist for other SAS users as well.
> 
> Signed-off-by: Brian King <brking@us.ibm.com>
> ---
> 
>  linux-2.6-bjking1/drivers/ata/libata-core.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/ata/libata-core.c~libata_subsys_init drivers/ata/libata-core.c
> --- linux-2.6/drivers/ata/libata-core.c~libata_subsys_init	2006-10-23 16:48:15.000000000 -0500
> +++ linux-2.6-bjking1/drivers/ata/libata-core.c	2006-10-23 16:48:15.000000000 -0500
> @@ -5957,7 +5957,7 @@ static void __exit ata_exit(void)
>  	destroy_workqueue(ata_aux_wq);
>  }
>  
> -module_init(ata_init);
> +subsys_initcall(ata_init);
>  module_exit(ata_exit);
>  
>  static unsigned long ratelimit_time;
> _


-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center