Re: [PATCH 2/2 #upstream] ahci: honor PORTS_IMPL on ICH8s

[Tejun Heo <htejun@gmail.com>]

Tejun Heo wrote:
> Some ICH8s use non-linear port mapping.  ahci driver didn't use to
> honor PORTS_IMPL and this made ports after hole nonfunctional.  This
> patch makes ahci mark those ports as dummy and properly initialize all
> the implemented ports after the dummies.
> 
> As it's unknown whether other AHCIs implement PORTS_IMPL register
> properly, new board id board_ahci_pi is added and selectively applied
> to ICH8s.  All other AHCIs continue to use linear mapping regardless
> of PORTS_IMPL value.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Robin H. Johnson <robbat2@gentoo.org>
> ---
> 
> Two changes.
> 
> * AHCI_FLAG_HONOR_PI was changed to 1<<25.  1<<23 is not for LLD
>   specific flags.
> 
> * VPRINTK() fixed as Robin H. Johnson pointed out.

Jeff, I think this should go into #upstream-fixes too.  It's not as dumb 
as adding a PCI ID but it's adding support for a highly popular hardware 
and "wait for 2.6.20 for ICH8 support" just sucks.

Thanks.

-- 
tejun