From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/4] libata: separate out rw ATA taskfile building into ata_build_tf()
Date: Tue, 14 Nov 2006 16:04:53 -0500 [thread overview]
Message-ID: <455A2F75.6050003@rtr.ca> (raw)
In-Reply-To: <4559F3F7.4080509@gmail.com>
Tejun Heo wrote:
>
> First of all, that function is moved verbatim from ata_scsi_rw_xlat(),
Yeah, I knew that.
Don't mind me, I'm just have a bit of a scatterbrain day,
switching back and forth between reviewing patches,
and deep thinking about another task.
For some odd reason I thought "lba_48_ok" checked whether
or not a drive could do LBA48.. probably because I have a routine
by that exact name in several drivers of my own coding.
But of course it's different here: it's just checking the requested
block against the LBA48 range. But is this even necessary here?
Presumably we already checked the block number against the device
max before getting to this point?
Or did we? I don't actually see that code nearby,
but perhaps the SCSI mid-layer did it for us?
If not, *where* do we have that check?
Anyway, it will all work as is.
I'm just wondering if we can nuke a few lines or not.
Cheers
next prev parent reply other threads:[~2006-11-14 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 13:47 [PATCHSET] libata: improve media error handling Tejun Heo
2006-11-14 13:47 ` [PATCH 1/4] libata: implement ata_exec_internal_sg() Tejun Heo
2006-11-28 9:02 ` Jeff Garzik
2006-11-14 13:47 ` [PATCH 3/4] libata: prepare ata_sg_clean() for invocation from EH Tejun Heo
2006-11-28 9:02 ` Jeff Garzik
2006-11-14 13:47 ` [PATCH 2/4] libata: separate out rw ATA taskfile building into ata_build_tf() Tejun Heo
2006-11-14 16:13 ` Mark Lord
2006-11-14 16:51 ` Tejun Heo
2006-11-14 21:04 ` Mark Lord [this message]
2006-11-28 9:17 ` Jeff Garzik
2006-11-14 13:47 ` [PATCH 4/4] libata: improve media error handling Tejun Heo
2007-03-02 23:37 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455A2F75.6050003@rtr.ca \
--to=liml@rtr.ca \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).