From: Tejun Heo <htejun@gmail.com>
To: Andrei Tanas <andrei@tanas.ca>
Cc: 'Alan Cox' <alan@redhat.com>, 'Jeff Garzik' <jgarzik@pobox.com>,
linux-ide@vger.kernel.org
Subject: Re: pata_amd.c version 0.2.4
Date: Tue, 21 Nov 2006 17:12:36 +0900 [thread overview]
Message-ID: <4562B4F4.20004@gmail.com> (raw)
In-Reply-To: <005801c70359$b5f01010$21d03030$@ca>
Andrei Tanas wrote:
> Tejun, Jeff,
> In an attempt to enable suspend-to-ram (and correct resume) for NVidia MCP51
> PATA device, I added
> .suspend = ata_pci_device_suspend,
> .resume = ata_pci_device_resume,
> To amd_pci_driver struct. With this, first attempt to suspend results in an
> error (-16 "device is still active"), and second attempt leads to oops. Do
> you want to see console output and lspci for this?
>
> Leaving .suspend = NULL and adding only
> .resume = ata_pci_device_resume,
> seems to reset the device properly and work fine.
> Before this was enabled, the box would suspend/resume fine than hang
> silently about 30 seconds after resume.
You also need to set scsi_host_template->suspend/resume callbacks.
Using default ata_scsi_device_suspend() and ata_scsi_device_resume()
should be sufficient.
--
tejun
prev parent reply other threads:[~2006-11-21 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <006501c70286$6e562100$4b026300$@ca>
[not found] ` <20061107161322.GA25397@devserv.devel.redhat.com>
[not found] ` <008c01c702a5$e4482060$acd86120$@ca>
[not found] ` <20061107221507.GA21232@devserv.devel.redhat.com>
[not found] ` <00ea01c70343$225582b0$67008810$@ca>
[not found] ` <20061108160725.GA24966@devserv.devel.redhat.com>
2006-11-08 17:16 ` pata_amd.c version 0.2.4 Andrei Tanas
2006-11-21 8:12 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4562B4F4.20004@gmail.com \
--to=htejun@gmail.com \
--cc=alan@redhat.com \
--cc=andrei@tanas.ca \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).