* RE: pata_amd.c version 0.2.4 [not found] ` <20061108160725.GA24966@devserv.devel.redhat.com> @ 2006-11-08 17:16 ` Andrei Tanas 2006-11-21 8:12 ` Tejun Heo 0 siblings, 1 reply; 2+ messages in thread From: Andrei Tanas @ 2006-11-08 17:16 UTC (permalink / raw) To: 'Alan Cox', 'Jeff Garzik', 'Tejun Heo'; +Cc: linux-ide Tejun, Jeff, In an attempt to enable suspend-to-ram (and correct resume) for NVidia MCP51 PATA device, I added .suspend = ata_pci_device_suspend, .resume = ata_pci_device_resume, To amd_pci_driver struct. With this, first attempt to suspend results in an error (-16 "device is still active"), and second attempt leads to oops. Do you want to see console output and lspci for this? Leaving .suspend = NULL and adding only .resume = ata_pci_device_resume, seems to reset the device properly and work fine. Before this was enabled, the box would suspend/resume fine than hang silently about 30 seconds after resume. -----Original Message----- From: Alan Cox [mailto:alan@redhat.com] Sent: November 8, 2006 11:07 AM To: Andrei Tanas Cc: 'Alan Cox' Subject: Re: pata_amd.c version 0.2.4 On Wed, Nov 08, 2006 at 09:35:20AM -0500, Andrei Tanas wrote: > Adding .resume helped - the controller (MCP51) resets properly. Trying to > add .suspend resulted in an error (-16, "device is still active"), with > subsequent oops on the next suspend attempt. Let me know if you want console > output and lspci for this. I don't really have time to look at it this year, Tejun and Jeff may well be interested - is that the device you were suspending too ? ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: pata_amd.c version 0.2.4 2006-11-08 17:16 ` pata_amd.c version 0.2.4 Andrei Tanas @ 2006-11-21 8:12 ` Tejun Heo 0 siblings, 0 replies; 2+ messages in thread From: Tejun Heo @ 2006-11-21 8:12 UTC (permalink / raw) To: Andrei Tanas; +Cc: 'Alan Cox', 'Jeff Garzik', linux-ide Andrei Tanas wrote: > Tejun, Jeff, > In an attempt to enable suspend-to-ram (and correct resume) for NVidia MCP51 > PATA device, I added > .suspend = ata_pci_device_suspend, > .resume = ata_pci_device_resume, > To amd_pci_driver struct. With this, first attempt to suspend results in an > error (-16 "device is still active"), and second attempt leads to oops. Do > you want to see console output and lspci for this? > > Leaving .suspend = NULL and adding only > .resume = ata_pci_device_resume, > seems to reset the device properly and work fine. > Before this was enabled, the box would suspend/resume fine than hang > silently about 30 seconds after resume. You also need to set scsi_host_template->suspend/resume callbacks. Using default ata_scsi_device_suspend() and ata_scsi_device_resume() should be sufficient. -- tejun ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-21 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <006501c70286$6e562100$4b026300$@ca>
[not found] ` <20061107161322.GA25397@devserv.devel.redhat.com>
[not found] ` <008c01c702a5$e4482060$acd86120$@ca>
[not found] ` <20061107221507.GA21232@devserv.devel.redhat.com>
[not found] ` <00ea01c70343$225582b0$67008810$@ca>
[not found] ` <20061108160725.GA24966@devserv.devel.redhat.com>
2006-11-08 17:16 ` pata_amd.c version 0.2.4 Andrei Tanas
2006-11-21 8:12 ` Tejun Heo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).