From: Tejun Heo <htejun@gmail.com>
To: "Gaston, Jason D" <jason.d.gaston@intel.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc6] ata_piix: IDE mode SATA patch for Intel ICH9
Date: Wed, 22 Nov 2006 10:03:31 +0900 [thread overview]
Message-ID: <4563A1E3.1030703@gmail.com> (raw)
In-Reply-To: <39B20DF628532344BC7A2692CB6AEE07A5A310@orsmsx420.amr.corp.intel.com>
Gaston, Jason D wrote:
> Did this come through ok, using Evolution, or do I need to try a
> different email client and send again?
It's wrapped and more comments below.
> -----Original Message-----
> From: Gaston, Jason D
> Sent: Tuesday, November 21, 2006 2:52 PM
> To: jgarzik@pobox.com; linux-ide@vger.kernel.org;
> linux-kernel@vger.kernel.org; Gaston, Jason D
> Subject: [PATCH 2.6.19-rc6] ata_piix: IDE mode SATA patch for Intel ICH9
>
> This patch adds the Intel ICH9 IDE mode SATA controller DID's.
>
> Signed-off-by: Jason Gaston <jason.d.gaston@intel.com>
>
> --- linux-2.6.19-rc6/drivers/ata/ata_piix.c.orig 2006-11-20
> 04:58:48.000000000 -0800
> +++ linux-2.6.19-rc6/drivers/ata/ata_piix.c 2006-11-20
> 06:15:12.000000000 -0800
Above two lines are wrapped.
> @@ -127,6 +127,7 @@
> ich6_sata_ahci = 8,
> ich6m_sata_ahci = 9,
> ich8_sata_ahci = 10,
> + ich9_sata_ahci = 11,
AFAICS, ich9 isn't different from ich8. Any reason not to simply use
ich8_sata_ahci?
[--snip--]
> +static const struct piix_map_db ich9_map_db = {
> + .mask = 0x3,
> + .port_enable = 0x3,
> + .present_shift = 8,
I guess this patch is against libata-dev#upstream-fixes. Just FYI
.present_shift is gone in libata-dev#upstream.
--
tejun
next prev parent reply other threads:[~2006-11-22 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 0:37 [PATCH 2.6.19-rc6] ata_piix: IDE mode SATA patch for Intel ICH9 Gaston, Jason D
2006-11-22 1:03 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-21 22:51 Jason Gaston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4563A1E3.1030703@gmail.com \
--to=htejun@gmail.com \
--cc=jason.d.gaston@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).