From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Robert Hancock <hancockr@shaw.ca>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Nicolas.Mailhot@LaPoste.net
Subject: Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode
Date: Mon, 27 Nov 2006 18:31:44 -0500 [thread overview]
Message-ID: <456B7560.2020301@garzik.org> (raw)
In-Reply-To: <20061127151541.16a93d49.akpm@osdl.org>
Andrew Morton wrote:
> On Sun, 26 Nov 2006 14:20:19 -0600
> Robert Hancock <hancockr@shaw.ca> wrote:
>
>> static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance)
>> {
>> struct ata_host *host = dev_instance;
>> int i, handled = 0;
>> + u32 notifier_clears[2];
>>
>> spin_lock(&host->lock);
>>
>> for (i = 0; i < host->n_ports; i++) {
>> struct ata_port *ap = host->ports[i];
>> + notifier_clears[i] = 0;
>
> Promise us that n_ports will never exceed 2?
ADMA spec is only defined for two channels, at least.
Jeff
next prev parent reply other threads:[~2006-11-27 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 20:20 [PATCH -mm] sata_nv: fix ATAPI in ADMA mode Robert Hancock
2006-11-27 23:15 ` Andrew Morton
2006-11-27 23:31 ` Jeff Garzik [this message]
2006-11-27 23:32 ` Jeff Garzik
2006-11-28 1:51 ` Allen Martin
2006-11-28 8:39 ` Jeff Garzik
2006-12-01 12:41 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456B7560.2020301@garzik.org \
--to=jeff@garzik.org \
--cc=Nicolas.Mailhot@LaPoste.net \
--cc=akpm@osdl.org \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).