From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Nicolas.Mailhot@LaPoste.net
Subject: Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode
Date: Tue, 28 Nov 2006 03:39:29 -0500 [thread overview]
Message-ID: <456BF5C1.9010506@garzik.org> (raw)
In-Reply-To: <4569F703.8010209@shaw.ca>
Robert Hancock wrote:
> The attached patch against 2.6.19-rc6-mm1 fixes some problems in sata_nv
> with ATAPI devices on controllers running in ADMA mode. Some of the
> logic in the nv_adma_bmdma_* functions was inverted causing a bunch of
> warnings and caused those functions not to work properly. Also, when an
> ATAPI device is connected, we need to use the legacy DMA engine. The
> code now disables the PCI configuration register bits for ADMA so that
> this works, and ensures that no ATAPI DMA commands go through until this
> is done.
>
> Fixes Bugzilla http://bugzilla.kernel.org/show_bug.cgi?id=7538
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
applied
In the future, please use "---" not "--" as the separator your .sig, so
that it is not copied into the kernel changelog by git-applymbox.
also, please avoid MIME attachments and include the patch inline.
next prev parent reply other threads:[~2006-11-28 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 20:20 [PATCH -mm] sata_nv: fix ATAPI in ADMA mode Robert Hancock
2006-11-27 23:15 ` Andrew Morton
2006-11-27 23:31 ` Jeff Garzik
2006-11-27 23:32 ` Jeff Garzik
2006-11-28 1:51 ` Allen Martin
2006-11-28 8:39 ` Jeff Garzik [this message]
2006-12-01 12:41 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456BF5C1.9010506@garzik.org \
--to=jeff@garzik.org \
--cc=Nicolas.Mailhot@LaPoste.net \
--cc=akpm@osdl.org \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).