From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix scsi_host_template in drivers
Date: Tue, 28 Nov 2006 17:50:09 +0900 [thread overview]
Message-ID: <456BF841.5010102@gmail.com> (raw)
In-Reply-To: <456BF685.3090004@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>> This patch fixes the followings regarding sht usage in libata drivers.
>>
>> * sht->max_sectors is overrided unconditionally in ->slave_configure.
>> There's no reason to set it to any value.
>>
>> * Many LLDs are missing sht->slave_destroy. The method is mandatory
>> to support device warm unplugging (echo 1 > /sys/.../delete).
>> Without it, libata might access released scsi device.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> ---
>>
>> Another candidate for #upstream-fixes.
>
> if you want stuff in #upstream-fixes, you have to cut the patch down to
> its bare minimum. the max_sectors change in this case is a cleanup.
>
> I ACK the patch, but ask: would you prefer to split the patch, or just
> this into #upstream?
I'll split.
--
tejun
prev parent reply other threads:[~2006-11-28 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 6:04 [PATCH] libata: fix scsi_host_template in drivers Tejun Heo
2006-11-28 8:42 ` Jeff Garzik
2006-11-28 8:50 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456BF841.5010102@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).