From: Mark Lord <liml@rtr.ca>
To: albertl@mail.com
Cc: Jeff Garzik <jeff@garzik.org>,
Linux IDE <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Tejun Heo <htejun@gmail.com>,
matthieu castet <castet.matthieu@free.fr>,
Tobias Powalowski <t.powa@gmx.de>
Subject: Re: [PATCH] libata: waits up to 10 microseconds for early irq problem
Date: Tue, 28 Nov 2006 09:42:20 -0500 [thread overview]
Message-ID: <456C4ACC.1050806@rtr.ca> (raw)
In-Reply-To: <456C4514.9090107@tw.ibm.com>
Albert Lee wrote:
> It's worthwhile to poll alt_status and wait for BSY to clear in this case.
Polling the ATA ALT_STATUS register can take up to 600ns,
or the equivalent of several thousand wasted instructions
on a modern CPU.
It's only worthwhile if the poll was actually necessary.
My question is, do we really want this overhead in the hot path
on every single ATA interrupt, or should we instead simply blacklist
those devices with the problem?
Or perhaps be more clever in handling it: If the device driver interrupt
routine see's BUSY still set after the normal ATA STATUS read,
*then* we could do the poll. That way it never adds unnecessary overhead.
This is more than "just a single instruction" here.. it's the equivalent
of thousands of them, each time we read an ATA register.
Cheers
next prev parent reply other threads:[~2006-11-28 14:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611180759.34622.t.powa@gmx.de>
[not found] ` <20061118002357.564dbb9d.akpm@osdl.org>
2006-11-18 21:20 ` possibility to merge via_pata fixes to .19 stable series? Jeff Garzik
2006-11-18 22:43 ` Alan
2006-11-19 3:07 ` Andrew Morton
2006-11-19 5:34 ` Tejun Heo
2006-11-19 6:02 ` Andrew Morton
2006-11-28 6:52 ` [PATCH] libata: waits up to 10 microseconds for early irq problem Albert Lee
2006-11-28 10:25 ` Alan
2006-11-28 10:27 ` Tejun Heo
2006-11-28 10:46 ` Alan
2006-11-28 14:00 ` Mark Lord
2006-11-28 14:12 ` Alan
2006-11-28 14:16 ` Mark Lord
2006-11-28 11:32 ` Albert Lee
2006-11-28 14:17 ` Albert Lee
2006-11-28 14:42 ` Mark Lord [this message]
2006-11-28 19:13 ` Jeff Garzik
2006-11-30 9:43 ` [PATCH] libata: blacklist " Albert Lee
2006-11-30 11:29 ` Alan
2006-11-30 20:37 ` Mark Lord
2006-11-30 20:45 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456C4ACC.1050806@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=castet.matthieu@free.fr \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=t.powa@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).