From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix SCSI/ATA device association during hotplug
Date: Wed, 29 Nov 2006 02:14:59 +0900 [thread overview]
Message-ID: <456C6E93.9040203@gmail.com> (raw)
In-Reply-To: <456C43BF.4060807@rtr.ca>
Mark Lord wrote:
> Tejun Heo wrote:
> ..
>> + /* Try to attach new SCSI device. SCSI midlayer
>> + * doesn't supply separate interfaces for allocating
>> + * and probing, so in this function, we can associate
>> + * new SCSI device with its target ATA device only
>> + * after probing is complete.
> ..
>
> I'm not necessarily disagreeing with the code, but rather that comment.
>
> Mmm.. isn't slave_alloc() for allocating? It gets invoked before
> the INQUIRY, and then slave_configure() is invoked after a successful
> device INQUIRY (otherwise slave_destroy() is invoked to clean up).
Yeah, right. That will be the perfect place to attach ATA device.
Thanks for pointing out. I'll redo this patch.
--
tejun
next prev parent reply other threads:[~2006-11-28 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 9:25 [PATCH] libata: fix SCSI/ATA device association during hotplug Tejun Heo
2006-11-28 9:07 ` Jeff Garzik
2006-11-28 14:12 ` Mark Lord
2006-11-28 17:14 ` Tejun Heo [this message]
2006-12-12 4:24 ` [PATCH] libata: fix SCSI/ATA device association during hotplug, take 2 Tejun Heo
2006-12-12 4:29 ` [PATCH] libata: use ata_scsi_find_dev() in ata_scsi_slave_config() Tejun Heo
2007-03-02 23:44 ` [PATCH] libata: fix SCSI/ATA device association during hotplug, take 2 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456C6E93.9040203@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).