From: Jeff Garzik <jgarzik@pobox.com>
To: Peer Chen <pchen@nvidia.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c
Date: Thu, 30 Nov 2006 05:42:48 -0500 [thread overview]
Message-ID: <456EB5A8.2060107@pobox.com> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B0D588DC0@hkemmail01.nvidia.com>
Peer Chen wrote:
> Move the device IDs of MCP65/MCP67 from sata_nv.c to ahci.c.
> The patch will be applied to kernel 2.6.19.
> Please check attachment for the patch.
>
> Signed-off-by: Peer Chen <pchen@nvidia.com>
Please update as follows:
1) Provide a detailed explanation as to /why/ this is needed. I
certainly encourage use of ahci over legacy mode, but the patch
description tells us nothing.
2) Combine the two patches into one. Think of a patch as an atomic
operation. If you apply your patches as submitted, then a 'git bisect'
may reach a state where the PCI IDs exist in _neither_ sata_nv or ahci.
Any time you /move/ code or data, it should be in the same patch.
3) Your patches are completely unreviewable in a standard Internet
mailer, because they were sent with your email base64-encoded. For many
mailers, base64 encoding means the patch is not shown nor able to be
commented upon. Indeed, some mailers make it difficult to response -at
all- to data contained in a MIME attachment.
The change itself seems OK, once suitable justification is provided.
Jeff
next prev parent reply other threads:[~2006-11-30 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 9:40 [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c Peer Chen
2006-11-30 10:42 ` Jeff Garzik [this message]
2006-12-04 13:49 ` Peer Chen
2006-12-20 19:19 ` Jeff Garzik
2006-12-21 3:39 ` Peer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456EB5A8.2060107@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).