* [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c
@ 2006-11-30 9:40 Peer Chen
2006-11-30 10:42 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Peer Chen @ 2006-11-30 9:40 UTC (permalink / raw)
To: linux-ide, linux-kernel; +Cc: Jeff Garzik, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
Move the device IDs of MCP65/MCP67 from sata_nv.c to ahci.c.
The patch will be applied to kernel 2.6.19.
Please check attachment for the patch.
Signed-off-by: Peer Chen <pchen@nvidia.com>
BRs
Peer Chen
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
[-- Attachment #2: patch.sata_nv --]
[-- Type: application/octet-stream, Size: 1010 bytes --]
--- linux-2.6.19/drivers/ata/sata_nv.c.orig 2006-11-30 14:20:42.000000000 +0800
+++ linux-2.6.19/drivers/ata/sata_nv.c 2006-11-30 14:23:16.000000000 +0800
@@ -117,14 +117,6 @@ static const struct pci_device_id nv_pci
{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), GENERIC },
{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), GENERIC },
{ PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), GENERIC },
- { PCI_VDEVICE(NVIDIA, 0x045c), GENERIC }, /* MCP65 */
- { PCI_VDEVICE(NVIDIA, 0x045d), GENERIC }, /* MCP65 */
- { PCI_VDEVICE(NVIDIA, 0x045e), GENERIC }, /* MCP65 */
- { PCI_VDEVICE(NVIDIA, 0x045f), GENERIC }, /* MCP65 */
- { PCI_VDEVICE(NVIDIA, 0x0550), GENERIC }, /* MCP67 */
- { PCI_VDEVICE(NVIDIA, 0x0551), GENERIC }, /* MCP67 */
- { PCI_VDEVICE(NVIDIA, 0x0552), GENERIC }, /* MCP67 */
- { PCI_VDEVICE(NVIDIA, 0x0553), GENERIC }, /* MCP67 */
{ PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC },
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c 2006-11-30 9:40 [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c Peer Chen @ 2006-11-30 10:42 ` Jeff Garzik 2006-12-04 13:49 ` Peer Chen 0 siblings, 1 reply; 5+ messages in thread From: Jeff Garzik @ 2006-11-30 10:42 UTC (permalink / raw) To: Peer Chen; +Cc: linux-ide, linux-kernel, Andrew Morton Peer Chen wrote: > Move the device IDs of MCP65/MCP67 from sata_nv.c to ahci.c. > The patch will be applied to kernel 2.6.19. > Please check attachment for the patch. > > Signed-off-by: Peer Chen <pchen@nvidia.com> Please update as follows: 1) Provide a detailed explanation as to /why/ this is needed. I certainly encourage use of ahci over legacy mode, but the patch description tells us nothing. 2) Combine the two patches into one. Think of a patch as an atomic operation. If you apply your patches as submitted, then a 'git bisect' may reach a state where the PCI IDs exist in _neither_ sata_nv or ahci. Any time you /move/ code or data, it should be in the same patch. 3) Your patches are completely unreviewable in a standard Internet mailer, because they were sent with your email base64-encoded. For many mailers, base64 encoding means the patch is not shown nor able to be commented upon. Indeed, some mailers make it difficult to response -at all- to data contained in a MIME attachment. The change itself seems OK, once suitable justification is provided. Jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c 2006-11-30 10:42 ` Jeff Garzik @ 2006-12-04 13:49 ` Peer Chen 2006-12-20 19:19 ` Jeff Garzik 0 siblings, 1 reply; 5+ messages in thread From: Peer Chen @ 2006-12-04 13:49 UTC (permalink / raw) To: Jeff Garzik; +Cc: linux-ide, linux-kernel, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 2192 bytes --] Resend the patch. The content of memory map io of BAR5 have been change from MCP65 then sata_nv can't work fine on the platform based on MCP65 and MCP67,so move their IDs from sata_nv.c to ahci.c. Please check attachment for new patch,thanks. Signed-off-by: Peer Chen <pchen@nvidia.com> -----Original Message----- From: Jeff Garzik [mailto:jgarzik@pobox.com] Sent: Thursday, November 30, 2006 6:43 PM To: Peer Chen Cc: linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton Subject: Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c Peer Chen wrote: > Move the device IDs of MCP65/MCP67 from sata_nv.c to ahci.c. > The patch will be applied to kernel 2.6.19. > Please check attachment for the patch. > > Signed-off-by: Peer Chen <pchen@nvidia.com> Please update as follows: 1) Provide a detailed explanation as to /why/ this is needed. I certainly encourage use of ahci over legacy mode, but the patch description tells us nothing. 2) Combine the two patches into one. Think of a patch as an atomic operation. If you apply your patches as submitted, then a 'git bisect' may reach a state where the PCI IDs exist in _neither_ sata_nv or ahci. Any time you /move/ code or data, it should be in the same patch. 3) Your patches are completely unreviewable in a standard Internet mailer, because they were sent with your email base64-encoded. For many mailers, base64 encoding means the patch is not shown nor able to be commented upon. Indeed, some mailers make it difficult to response -at all- to data contained in a MIME attachment. The change itself seems OK, once suitable justification is provided. Jeff ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- [-- Attachment #2: patch.sata_nv-ahci --] [-- Type: application/octet-stream, Size: 2333 bytes --] diff -uprN -X linux-2.6.19-vanilla/Documentation/dontdiff linux-2.6.19-vanilla/drivers/ata/ahci.c linux-2.6.19/drivers/ata/ahci.c --- linux-2.6.19-vanilla/drivers/ata/ahci.c 2006-11-30 05:57:37.000000000 +0800 +++ linux-2.6.19/drivers/ata/ahci.c 2006-12-04 17:34:26.000000000 +0800 @@ -345,6 +345,14 @@ static const struct pci_device_id ahci_p { PCI_VDEVICE(NVIDIA, 0x044d), board_ahci }, /* MCP65 */ { PCI_VDEVICE(NVIDIA, 0x044e), board_ahci }, /* MCP65 */ { PCI_VDEVICE(NVIDIA, 0x044f), board_ahci }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045c), board_ahci }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045d), board_ahci }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045e), board_ahci }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x045f), board_ahci }, /* MCP65 */ + { PCI_VDEVICE(NVIDIA, 0x0550), board_ahci }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0551), board_ahci }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0552), board_ahci }, /* MCP67 */ + { PCI_VDEVICE(NVIDIA, 0x0553), board_ahci }, /* MCP67 */ { PCI_VDEVICE(NVIDIA, 0x0554), board_ahci }, /* MCP67 */ { PCI_VDEVICE(NVIDIA, 0x0555), board_ahci }, /* MCP67 */ { PCI_VDEVICE(NVIDIA, 0x0556), board_ahci }, /* MCP67 */ diff -uprN -X linux-2.6.19-vanilla/Documentation/dontdiff linux-2.6.19-vanilla/drivers/ata/sata_nv.c linux-2.6.19/drivers/ata/sata_nv.c --- linux-2.6.19-vanilla/drivers/ata/sata_nv.c 2006-11-30 05:57:37.000000000 +0800 +++ linux-2.6.19/drivers/ata/sata_nv.c 2006-12-04 17:34:32.000000000 +0800 @@ -117,14 +117,6 @@ static const struct pci_device_id nv_pci { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA), GENERIC }, { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA2), GENERIC }, { PCI_VDEVICE(NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP61_SATA3), GENERIC }, - { PCI_VDEVICE(NVIDIA, 0x045c), GENERIC }, /* MCP65 */ - { PCI_VDEVICE(NVIDIA, 0x045d), GENERIC }, /* MCP65 */ - { PCI_VDEVICE(NVIDIA, 0x045e), GENERIC }, /* MCP65 */ - { PCI_VDEVICE(NVIDIA, 0x045f), GENERIC }, /* MCP65 */ - { PCI_VDEVICE(NVIDIA, 0x0550), GENERIC }, /* MCP67 */ - { PCI_VDEVICE(NVIDIA, 0x0551), GENERIC }, /* MCP67 */ - { PCI_VDEVICE(NVIDIA, 0x0552), GENERIC }, /* MCP67 */ - { PCI_VDEVICE(NVIDIA, 0x0553), GENERIC }, /* MCP67 */ { PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC }, ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c 2006-12-04 13:49 ` Peer Chen @ 2006-12-20 19:19 ` Jeff Garzik 2006-12-21 3:39 ` Peer Chen 0 siblings, 1 reply; 5+ messages in thread From: Jeff Garzik @ 2006-12-20 19:19 UTC (permalink / raw) To: Peer Chen; +Cc: linux-ide, linux-kernel, Andrew Morton Peer Chen wrote: > Resend the patch. > The content of memory map io of BAR5 have been change from MCP65 then sata_nv can't work fine on the platform based on MCP65 and MCP67,so move their IDs from sata_nv.c to ahci.c. > Please check attachment for new patch,thanks. > > Signed-off-by: Peer Chen <pchen@nvidia.com> Patch applied, manually. For future patches, 1) Please do not quote the original message 2) Please include patches inline, rather than as an attachment. Jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c 2006-12-20 19:19 ` Jeff Garzik @ 2006-12-21 3:39 ` Peer Chen 0 siblings, 0 replies; 5+ messages in thread From: Peer Chen @ 2006-12-21 3:39 UTC (permalink / raw) To: Jeff Garzik; +Cc: linux-ide, linux-kernel, Andrew Morton Thanks. BRs Peer Chen -----Original Message----- From: Jeff Garzik [mailto:jgarzik@pobox.com] Sent: Thursday, December 21, 2006 3:20 AM To: Peer Chen Cc: linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton Subject: Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c Peer Chen wrote: > Resend the patch. > The content of memory map io of BAR5 have been change from MCP65 then sata_nv can't work fine on the platform based on MCP65 and MCP67,so move their IDs from sata_nv.c to ahci.c. > Please check attachment for new patch,thanks. > > Signed-off-by: Peer Chen <pchen@nvidia.com> Patch applied, manually. For future patches, 1) Please do not quote the original message 2) Please include patches inline, rather than as an attachment. Jeff ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-12-21 3:45 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-11-30 9:40 [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c Peer Chen 2006-11-30 10:42 ` Jeff Garzik 2006-12-04 13:49 ` Peer Chen 2006-12-20 19:19 ` Jeff Garzik 2006-12-21 3:39 ` Peer Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).