From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: always use polling IDENTIFY
Date: Sun, 03 Dec 2006 06:14:18 -0500 [thread overview]
Message-ID: <4572B18A.8010206@pobox.com> (raw)
In-Reply-To: <20061203103032.GE11250@htj.dyndns.org>
Tejun Heo wrote:
> libata switched to IRQ-driven IDENTIFY when IRQ-driven PIO was
> introduced. This has caused a lot of problems including device
> misdetection and phantom device.
>
> ATA_FLAG_DETECT_POLLING was added recently to selectively use polling
> IDENTIFY on problemetic drivers but many controllers and devices are
> affected by this problem and trying to adding ATA_FLAG_DETECT_POLLING
> for each such case is diffcult and not very rewarding.
>
> This patch makes libata always use polling IDENTIFY. This is
> consistent with libata's original behavior and drivers/ide's behavior.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
ACK, but does not apply to #upstream[1], which includes the tj-upstream
that I pulled.
Jeff
[1] 8e16f941226f15622fbbc416a1f3d8705001a191
next prev parent reply other threads:[~2006-12-03 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 10:30 [PATCH] libata: always use polling IDENTIFY Tejun Heo
2006-12-03 11:14 ` Jeff Garzik [this message]
2006-12-03 12:34 ` [PATCH RESEND] " Tejun Heo
2006-12-03 12:58 ` Jeff Garzik
2006-12-03 12:56 ` [PATCH] " Alan
2006-12-03 13:02 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4572B18A.8010206@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).