From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion
Date: Sun, 03 Dec 2006 08:03:39 -0500 [thread overview]
Message-ID: <4572CB2B.8050406@garzik.org> (raw)
In-Reply-To: <4572CA7A.6010103@gmail.com>
Tejun Heo wrote:
> Hello, Mikael.
>
> Thanks for doing this.
>
> Mikael Pettersson wrote:
> [--snip--]
>> +static void pdc_freeze(struct ata_port *ap)
>> +{
>> + void __iomem *mmio = (void __iomem *) ap->ioaddr.cmd_addr;
>> + u32 tmp;
>> +
>> + tmp = readl(mmio + PDC_CTLSTAT);
>> + tmp |= PDC_IRQ_DISABLE;
>> + tmp &= ~PDC_DMA_ENABLE;
>> + writel(tmp, mmio + PDC_CTLSTAT);
>> + readl(mmio + PDC_CTLSTAT); /* flush *//* XXX: needed? sata_sil does this */
>
> Just drop the above line.
>
>> +}
>> +
>> +static void pdc_thaw(struct ata_port *ap)
>> +{
>> + void __iomem *mmio = (void __iomem *) ap->ioaddr.cmd_addr;
>> + u32 tmp;
>> +
>> + /* clear IRQ */
>> + readl(mmio + PDC_INT_SEQMASK);
>> +
>> + /* turn IRQ back on */
>> + tmp = readl(mmio + PDC_CTLSTAT);
>> + tmp &= ~PDC_IRQ_DISABLE;
>> + writel(tmp, mmio + PDC_CTLSTAT);
>> + readl(mmio + PDC_CTLSTAT); /* flush *//* XXX: needed? */
>
> Ditto.
Why do you think these flushes are not needed?
Jeff
next prev parent reply other threads:[~2006-12-03 13:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 9:58 [PATCH 2.6.19 2/3] sata_promise: new EH conversion Mikael Pettersson
2006-12-03 13:00 ` Tejun Heo
2006-12-03 13:03 ` Jeff Garzik [this message]
2006-12-03 13:19 ` Tejun Heo
2006-12-03 14:16 ` Arjan van de Ven
2006-12-06 9:38 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2006-12-06 8:52 Mikael Pettersson
2006-12-06 9:40 ` Tejun Heo
2006-12-06 8:53 Mikael Pettersson
2006-12-06 9:13 ` Jeff Garzik
2006-12-06 9:19 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4572CB2B.8050406@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).