From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: htejun@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19] sata_promise: cleanups, take 2
Date: Thu, 07 Dec 2006 07:21:41 -0500 [thread overview]
Message-ID: <45780755.3040404@garzik.org> (raw)
In-Reply-To: <200612060855.kB68th9a024699@harpo.it.uu.se>
Mikael Pettersson wrote:
> This patch performs two simple cleanups of sata_promise.
>
> * Remove board_20771 and map device id 0x3577 to board_2057x.
> After the recent corrections for SATAII chips, board_20771 and
> board_2057x were equivalent in the driver.
>
> * Remove hp->hotplug_offset and use hp->flags & PDC_FLAG_GEN_II
> to compute hotplug_offset in pdc_host_init(). hp->hotplug_offset
> was used to distinguish 1st and 2nd generation chips in one
> particular case, but now we have that information in a more
> general form in hp->flags, so hp->hotplug_offset is redundant.
>
> Changes since previous submission: rebased on libata-dev #upstream,
> cleaned up hotplug_offset computation based on Tejun's comments,
> expanded hotplug_offset removal rationale.
>
> This patch does not depend on the pending new EH conversion patch.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
applied
prev parent reply other threads:[~2006-12-07 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 8:55 [PATCH 2.6.19] sata_promise: cleanups, take 2 Mikael Pettersson
2006-12-07 12:21 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45780755.3040404@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).