* Re: [PATCH] libata: Incorrect timing computation for PIO5/6
2006-12-07 12:41 [PATCH] libata: Incorrect timing computation for PIO5/6 Alan
@ 2006-12-07 12:39 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-12-07 12:39 UTC (permalink / raw)
To: Alan; +Cc: linux-ide, akpm
Alan wrote:
> The ata timing computation code makes some mistakes in PIO5/6 because a
> check was not updated correctly when I put this support into the kernel.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] libata: Incorrect timing computation for PIO5/6
@ 2006-12-07 12:41 Alan
2006-12-07 12:39 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan @ 2006-12-07 12:41 UTC (permalink / raw)
To: jgarzik, linux-ide, akpm
The ata timing computation code makes some mistakes in PIO5/6 because a
check was not updated correctly when I put this support into the kernel.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc6-mm1/drivers/ata/libata-core.c linux-2.6.19-rc6-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.19-rc6-mm1/drivers/ata/libata-core.c 2006-11-24 13:58:28.000000000 +0000
+++ linux-2.6.19-rc6-mm1/drivers/ata/libata-core.c 2006-12-07 10:28:21.229413880 +0000
@@ -2164,7 +2164,7 @@
* DMA cycle timing is slower/equal than the fastest PIO timing.
*/
- if (speed > XFER_PIO_4) {
+ if (speed > XFER_PIO_6) {
ata_timing_compute(adev, adev->pio_mode, &p, T, UT);
ata_timing_merge(&p, t, t, ATA_TIMING_ALL);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-07 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-07 12:41 [PATCH] libata: Incorrect timing computation for PIO5/6 Alan
2006-12-07 12:39 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).