From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH -mm] sata_nv: fix kfree ordering in remove
Date: Tue, 12 Dec 2006 06:35:23 -0500 [thread overview]
Message-ID: <457E93FB.20204@garzik.org> (raw)
In-Reply-To: <457E3F6A.809@shaw.ca>
Robert Hancock wrote:
> Jeff Garzik wrote:
>> It is unwise to free the struct before the ports are even detached.
>
> Right, theoretically something bad could happen here (though not
> likely). Here's a fix. Sorry for attaching with something so trivial,
> but Thunderbird isn't very cooperative..
You'll need to resend the entire patch, I dropped it due to that
comment. In general, before a patch is applied, the patch will go
through several revisions. I don't apply things piecemeal, only the
last (hopefully perfect:)) revision.
Also, as your email already guessed, attachments are to be avoided :/
Jeff
prev parent reply other threads:[~2006-12-12 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 2:15 [PATCH -mm] sata_nv: add suspend/resume support Robert Hancock
2006-12-11 16:27 ` Jeff Garzik
2006-12-12 5:34 ` [PATCH -mm] sata_nv: fix kfree ordering in remove Robert Hancock
2006-12-12 11:35 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457E93FB.20204@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).