From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, bob@evoria.net,
nabble@theanthonys.net, alan@lxorguk.ukuu.org.uk,
matthias@urlichs.de, romieu@fr.zoreil.com
Subject: Re: [PATCH 2/3] libata: implement max_segment_size
Date: Sat, 16 Dec 2006 10:37:01 -0500 [thread overview]
Message-ID: <4584129D.4030803@pobox.com> (raw)
In-Reply-To: <20061216104844.GD5400@htj.dyndns.org>
Tejun Heo wrote:
> libata depeneded on sht->dma_boundary for demtermining maximum segment
> size. This is good enough for most controllers but inic1622 just had
> to be different and it locks up if segement size is 65536 while
> dma_boundary is 0xffff.
>
> This patch implements ap->max_segment_size which can be initialized
> via probe_ent (or port_info) and used in ->slave_config to configure
> maximum segment size. LLDs without braindamage can leave this alone.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
Just implement a custom ->slave_config in the driver. There is no need
to add anything to probe_ent, port, and port_info.
Jeff
next prev parent reply other threads:[~2006-12-16 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 10:48 [PATCH 1/3] libata: kill qc->nsect and cursect Tejun Heo
2006-12-16 10:48 ` [PATCH 2/3] libata: implement max_segment_size Tejun Heo
2006-12-16 10:49 ` [PATCH 3/3] sata_inic162x: finally, driver for initio 162x SATA controllers Tejun Heo
2006-12-16 15:37 ` Jeff Garzik [this message]
2006-12-16 10:55 ` Okay, ppl. Here's driver for inic162x Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4584129D.4030803@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bob@evoria.net \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=matthias@urlichs.de \
--cc=nabble@theanthonys.net \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).