From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
linux-ide@vger.kernel.org
Subject: Re: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static
Date: Sun, 17 Dec 2006 21:08:43 +0300 [thread overview]
Message-ID: <458587AB.5000108@ru.mvista.com> (raw)
In-Reply-To: <20061216135650.GA3388@stusta.de>
Hello.
Adrian Bunk wrote:
>>+toshiba-tc86c001-ide-driver-take-2.patch
> This patch makes the needlessly global init_hwif_tc86c001() static.
Duh, I hoped tha this driver may get into 2.6.20-rc1 and finally
overlooked this. Sigh, uou won't believe how much time this driver rewrite
spent in an unfinished state in my internal tree... :-/
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> BTW:
> I'm not sure whether it'd be a good idea to include such a driver for
> the legacy IDE subsystem without a libata based driver for the same
> hardware.
Well, I'd agree with Alan here. Don't expect me to convert this to libata
in the foreseeable future... I'd like to join the folks hacking on libata but
this certainly won't happen soon (if at all)...
WBR, Sergei
next prev parent reply other threads:[~2006-12-17 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061214225913.3338f677.akpm@osdl.org>
2006-12-15 14:46 ` OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1] Jiri Slaby
2006-12-15 19:24 ` Andrew Morton
2006-12-15 22:49 ` Jiri Slaby
2006-12-16 13:56 ` [-mm patch] drivers/ide/pci/tc86c001.c: make a function static Adrian Bunk
2006-12-16 14:18 ` Alan
2006-12-17 18:08 ` Sergei Shtylyov [this message]
2006-12-17 20:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458587AB.5000108@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).