From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/4] libata: clean up variable name usage in xlat related functions
Date: Wed, 20 Dec 2006 14:26:42 -0500 [thread overview]
Message-ID: <45898E72.5040002@pobox.com> (raw)
In-Reply-To: <20061217014508.GG5400@htj.dyndns.org>
Tejun Heo wrote:
> Variable names in xlat functions are quite confusing now. 'scsicmd'
> is used for CDB while qc->scsicmd points to struct scsi_cmnd while
> 'cmd' is used for struct scsi_cmnd.
>
> This patch cleans up variable names in xlat functions such that 'scmd'
> is used for struct scsi_cmnd and 'cdb' for CDB. Also, 'scmd' local
> variable is added if qc->scsicmd is used multiple times.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Okay, separated as suggested and regenerated against
> libata-dev#upstream-fixes.
applied 1-3 to #upstream-fixes
prev parent reply other threads:[~2006-12-20 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 1:45 [PATCH 1/4] libata: clean up variable name usage in xlat related functions Tejun Heo
2006-12-17 1:45 ` [PATCH 2/4] libata: kill @cdb argument from xlat methods Tejun Heo
2006-12-17 1:46 ` [PATCH 3/4] libata: take scmd->cmd_len into account when translating SCSI commands Tejun Heo
2006-12-17 1:46 ` [PATCH 4/4] SCSI: revert clear-garbage-after-CDB fix Tejun Heo
2006-12-20 19:26 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45898E72.5040002@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).