Re: AHCI NCQ on ESB2 (8086:2681) (RESOLVED)

[Bryan Boatright <boatright@ieee.org>]

Thanks.  The new ahci_reset_controller proc solved the problem.  
HOST_CAP is now correct for both NCQ and phy speed capability.

Bryan


Tejun Heo wrote:
> Bryan Boatright wrote:
>>
>> I hope this is an appropriate place to ask this question.  Googling for
>> answers turned up nothing.
>>
>> I am using kernel 2.6.19.1 and am trying to get NCQ support working.  My
>> Intel chipset (ESB2, see details below) should support NCQ, but it is
>> not returning the NCQ capabilities bit in the HBA Capabilities
>> register.  Here's the relevant dmesg output:
>
> Please test the latest Linus git-tree.  ahci used to clear CAP while
> resetting controller expecting it to set supported feature bits again.
> Apparently some controllers don't do it resulting in disabled NCQ.
> This was fixed recently by the following commit.
>
> Commit: 551c012d7eea3dc5ec063c7ff9c718d39e77634f
> Author: Tejun Heo <htejun@gmail.com>  2006-12-12 20:17:32
> Committer: Jeff Garzik <jeff@garzik.org>  2006-12-17 00:13:29
> Branches: upstream-fixes, upstream, quilt-init
> Follows: v2.6.19
> Precedes:
>
>    [PATCH] ahci: do not mangle saved HOST_CAP while resetting controller
>
>    Do not mangle with HOST_CAP while resetting controller.  The code is
>    there for a historical reason.  The mangling breaks controller feature
>    detection and 0 PORTS_IMPL workaround code.
>
>    This problem was spotted by Manoj Kasichainula.
>
>    Signed-off-by: Tejun Heo <htejun@gmail.com>
>    Cc: Manoj Kasichainula <manoj@io.com>
>    Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> Happy new year.
>