From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement HDIO_GET_IDENTITY
Date: Wed, 03 Jan 2007 02:59:29 +0900 [thread overview]
Message-ID: <459A9D81.8040904@gmail.com> (raw)
In-Reply-To: <459A9AA8.5060808@rtr.ca>
Mark Lord wrote:
> Tejun Heo wrote:
>> 'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
>> spread yet leaving no easy way to access ATAPI IDENTIFY data.
>> Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
>
> Mmm.. I still think this old ioctl is ugly, and I'd rather
> have things fixed so that "hdparm -I" works instead.
Me agrees. Please drop HDIO_GET_IDENTITY patch.
> Unless having access to the libata cached ID block is useful
> beyond just getting ATAPI drives to work with -I.
> Is it? I suppose it might be useful to be able to look at it.
No, it's just to allow access to ATAPI IDENTIFY block. libata does
pretty good job of keeping ID block in sync via revalidating, so they
should be the same.
> hdparm *does* try to issue the PACKET IDENTIFY whenever
> a regular IDENTIFY fails. Currently these all go through
> the HDIO_DRIVE_CMD ioctl(). I don't have a system set up
> here that has any ATAPI over libata to test with.
> Could you perhaps try and see where that ioctl() is failing?
Ah.. Okay, so that's the second HDIO_DRIVE_CMD. I'll test why the
second one is failing tomorrow.
--
tejun
next prev parent reply other threads:[~2007-01-02 17:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 11:18 [PATCH 1/3] libata: straighten out ATA_ID_* constants Tejun Heo
2007-01-02 11:19 ` [PATCH 2/3] libata: use ata_id_c_string() Tejun Heo
2007-01-02 11:20 ` [PATCH] libata: implement HDIO_GET_IDENTITY Tejun Heo
2007-01-02 11:21 ` [PATCH *3/3*] " Tejun Heo
2007-01-02 17:47 ` [PATCH] " Mark Lord
2007-01-02 17:59 ` Tejun Heo [this message]
2007-01-02 18:18 ` Mark Lord
2007-01-02 21:52 ` Mark Lord
2007-01-08 2:29 ` Jeff Garzik
2007-01-08 4:00 ` Tejun Heo
2007-01-25 1:22 ` Jeff Garzik
2007-01-25 5:14 ` Mark Lord
2007-01-25 7:42 ` Jeff Garzik
2007-01-09 10:42 ` [PATCH 1/3] libata: straighten out ATA_ID_* constants Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459A9D81.8040904@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).