From: Mark Lord <liml@rtr.ca>
To: Mark Lord <liml@rtr.ca>
Cc: Tejun Heo <htejun@gmail.com>, Jeff Garzik <jgarzik@pobox.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement HDIO_GET_IDENTITY
Date: Tue, 02 Jan 2007 16:52:17 -0500 [thread overview]
Message-ID: <459AD411.1010307@rtr.ca> (raw)
In-Reply-To: <459AA1F8.7080402@rtr.ca>
(pardon the duplicate posting -- just trying to get it into the correct thread).
Tejun Heo wrote:
> Mark Lord wrote:
>> Tejun Heo wrote:
..
>>> Support for IDENTIFY PACKET DEVICE would be nice too.
>> It already does that, using HDIO_DRIVE_CMD to retrieve it
>> in the same way as for regular IDENTIFY DEVICE commands.
>
> Hmmm... My hdparm doesn't seem to do that.
>
> # hdparm -V
> hdparm v6.9
> # hdparm -I /dev/sr0
>
> /dev/sr0:
> HDIO_DRIVE_CMD(identify) failed: Input/output error
>
> Am I missing something?
Okay, I've dug through the code and found bugs in SCSI and libata.
After fixing those, "hdparm -I" now works unmodified for libata ATAPI.
I'll post fixes shortly, after some more testing.
Cheers
next prev parent reply other threads:[~2007-01-02 21:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 11:18 [PATCH 1/3] libata: straighten out ATA_ID_* constants Tejun Heo
2007-01-02 11:19 ` [PATCH 2/3] libata: use ata_id_c_string() Tejun Heo
2007-01-02 11:20 ` [PATCH] libata: implement HDIO_GET_IDENTITY Tejun Heo
2007-01-02 11:21 ` [PATCH *3/3*] " Tejun Heo
2007-01-02 17:47 ` [PATCH] " Mark Lord
2007-01-02 17:59 ` Tejun Heo
2007-01-02 18:18 ` Mark Lord
2007-01-02 21:52 ` Mark Lord [this message]
2007-01-08 2:29 ` Jeff Garzik
2007-01-08 4:00 ` Tejun Heo
2007-01-25 1:22 ` Jeff Garzik
2007-01-25 5:14 ` Mark Lord
2007-01-25 7:42 ` Jeff Garzik
2007-01-09 10:42 ` [PATCH 1/3] libata: straighten out ATA_ID_* constants Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459AD411.1010307@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).