From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl Date: Tue, 02 Jan 2007 17:39:49 -0500 Message-ID: <459ADF35.2060908@rtr.ca> References: <200701021724.39613.liml@rtr.ca> <459ADD70.9030402@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <459ADD70.9030402@pobox.com> Sender: linux-scsi-owner@vger.kernel.org To: Jeff Garzik Cc: Tejun Heo , IDE/ATA development list , linux-scsi@vger.kernel.org List-Id: linux-ide@vger.kernel.org Jeff Garzik wrote: > Mark Lord wrote: ... >> ret = cdrom_ioctl(file, &cd->cdi, inode, cmd, arg); >> - if (ret != ENOSYS) >> + if (ret != -ENOSYS) > > I think Tejun posted the same patch earlier today. Ahh.. missed it -- could have saved me an hour or two of debugging! Cheers!