From: Jeff Garzik <jeff@garzik.org>
To: Uwe Koziolek <uwe.koziolek@gmx.net>
Cc: Alan <alan@lxorguk.ukuu.org.uk>,
"linux.ide" <linux-ide@vger.kernel.org>,
Sven Ladegast <sven@linux4geeks.de>
Subject: Re: [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support
Date: Sun, 07 Jan 2007 20:33:27 -0500 [thread overview]
Message-ID: <45A19F67.6050909@garzik.org> (raw)
Uwe Koziolek wrote:
> This patch includes the PATA support for SiS180 importing PATA functionality from pata_sis.c
>
> Signed-off-by: Uwe Koziolek <uwe.koziolek@gmx.net>
>
> --- a/drivers/ata/sata_sis.c 2007-01-07 20:54:38.000000000 +0100
> +++ b/drivers/ata/sata_sis.c 2007-01-07 23:42:29.000000000 +0100
> @@ -138,6 +138,10 @@
> .port_ops = &sis_ops,
> };
>
> +#ifdef CONFIG_PATA_SIS
> +extern struct ata_port_info sis_info133;
> +#endif
This is a poor way to share code between modules. It fails when
pata_sis is a module, and it forces another driver to be loaded, simply
then to be used as a code library.
If the shared code is tiny, just create a header file and #include it
(sata_promise and sata_sx4 do this). Otherwise, create a shared library
module.
Jeff
next reply other threads:[~2007-01-08 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 1:33 Jeff Garzik [this message]
2007-01-08 10:28 ` [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support Alan
2007-01-08 11:44 ` Jeff Garzik
2007-01-08 12:51 ` Alan
2007-01-08 12:50 ` Jeff Garzik
2007-01-08 15:30 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A19F67.6050909@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sven@linux4geeks.de \
--cc=uwe.koziolek@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).