From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH libata #promise-sata-pata] sata_promise: unbreak 20619
Date: Sun, 07 Jan 2007 20:46:13 -0500 [thread overview]
Message-ID: <45A1A265.20504@garzik.org> (raw)
In-Reply-To: <200701062031.l06KV64q022234@harpo.it.uu.se>
Mikael Pettersson wrote:
> The PATA support patch for sata_promise appears, from
> code inspection, to break the PATA-only 20619 chip.
>
> The patch removes the SATA flag from the TX2plus SATA+PATA
> boards' common flags, with the intention of adding it back
> via the _port_flags[] entries for those boards' SATA ports.
>
> However, it unconditionally marks ports 0 and 1 as SATA
> for all boards. This causes the 20619 (TX4000) to announce
> its first two PATA ports as SATA | ATA_FLAG_SLAVE_POSS.
>
> I don't have a TX4000 so I don't know what the actual
> consequences of this bug are, but surely this isn't Ok.
>
> Fixed by moving the port 0 and 1 settings as SATA into
> the TX4 and TX2plus specific initialisation code.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Given that I agree with your RFC, this means I can drop all these
#promise-sata-pata patches, and kill the #promise-sata-pata branch soon,
right?
Jeff
next prev parent reply other threads:[~2007-01-08 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 20:31 [PATCH libata #promise-sata-pata] sata_promise: unbreak 20619 Mikael Pettersson
2007-01-08 1:46 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-08 8:07 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A1A265.20504@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).