From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ia64: add pci_get_legacy_ide_irq() (was: [2.6 patch] let BLK_DEV_AMD74XX depend on X86)
Date: Thu, 11 Jan 2007 16:49:30 +0100 [thread overview]
Message-ID: <45A65C8A.9080601@gmail.com> (raw)
Adrian Bunk wrote:
>
> It's unlikely that this driver will ever be of any use on other
> architectures.
It is already used on PPC.
[ see arch/powerpc/platforms/maple/pci.c:maple_pci_get_legacy_ide_irq() ]
> This fixes the following compile error on ia64:
>
> <-- snip -->
>
> ...
> CC drivers/ide/pci/amd74xx.o
> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:
> In function 'init_hwif_amd74xx':
> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:421:
>
> warning: implicit declaration of function 'pci_get_legacy_ide_irq'
> CC drivers/ide/pci/cmd64x.o
> ...
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `init_hwif_amd74xx':
> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c:421:
>
> undefined reference to `pci_get_legacy_ide_irq'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> <-- snip -->
>
>
> This fixes kernel Bugzilla #6644.
Does the following patch fix the problem?
[PATCH] ia64: add pci_get_legacy_ide_irq()
Add pci_get_legacy_ide_irq() identical to the one used by i386/x86_64.
Fixes amd74xx driver build on ia64 (bugzilla bug #6644).
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
include/asm-ia64/pci.h | 6 ++++++
1 file changed, 6 insertions(+)
Index: a/include/asm-ia64/pci.h
===================================================================
--- a.orig/include/asm-ia64/pci.h
+++ a/include/asm-ia64/pci.h
@@ -167,4 +167,10 @@ pcibios_select_root(struct pci_dev *pdev
#define pcibios_scan_all_fns(a, b) 0
+#define HAVE_ARCH_PCI_GET_LEGACY_IDE_IRQ
+static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
+{
+ return channel ? 15 : 14;
+}
+
#endif /* _ASM_IA64_PCI_H */
next reply other threads:[~2007-01-11 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 15:49 Bartlomiej Zolnierkiewicz [this message]
2007-01-11 23:39 ` [PATCH] ia64: add pci_get_legacy_ide_irq() (was: [2.6 patch] let BLK_DEV_AMD74XX depend on X86) Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A65C8A.9080601@gmail.com \
--to=bzolnier@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).