From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Hancock Subject: Re: [PATCH -mm] sata_nv: cleanup ADMA error handling Date: Mon, 15 Jan 2007 08:28:50 -0600 Message-ID: <45AB8FA2.50909@shaw.ca> References: <45AAE981.60906@shaw.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10]:16494 "EHLO pd2mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741AbXAOObz (ORCPT ); Mon, 15 Jan 2007 09:31:55 -0500 In-reply-to: <45AAE981.60906@shaw.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: linux-kernel , linux-ide@vger.kernel.org Cc: Jeff Garzik , Allen Martin Robert Hancock wrote: > -In the error_handler function the code would always go through and do > an ADMA channel reset and also dump out the state of all the CPBs. This > reset seems heinous in this situation since we haven't even decided to > reset anything yet. The output seems redundant at this point since > libata already dumps the state of all active commands on errors (and it > also triggers at times when it shouldn't, like when suspending). Do the > ADMA reset only on hardreset and remove the output. Actually, upon further thought some of this stuff really should be done in the error_handler method, just maybe not the channel reset. I'll cut another patch shortly.