From: Tejun Heo <htejun@gmail.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Brian King <brking@linux.vnet.ibm.com>,
Jeff Garzik <jgarzik@pobox.com>, Alan <alan@lxorguk.ukuu.org.uk>,
linux-scsi@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata: initialize qc->dma_dir to DMA_NONE
Date: Thu, 18 Jan 2007 00:49:29 +0900 [thread overview]
Message-ID: <45AE4589.4070309@gmail.com> (raw)
In-Reply-To: <1169047153.3416.5.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
> This looks perfectly fine as a possible solution. Is there any reason
> not to initialise qc->dma_dir unconditionally from the SCSI command?
That should work too. I did what I did because it was more in line with
what the current code assumed and initializing the field on qc alloc
seemed like a good idea with or without unconditional qc->dma_dir =
scmd->sc_data_direction because not all commands are translated from
scsi command.
> The only potential problem is DMA_BIDIRECTIONAL, which we don't use
> (yet) ... but if it ever did come down libata will do the wrong thing
> anyway.
If that ever happens, libata probably should emulate it using multiple
commands, I guess.
Thanks.
--
tejun
next prev parent reply other threads:[~2007-01-17 15:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 22:24 ipr SATA problems in 2.6.20 Brian King
2007-01-16 22:41 ` Alan
2007-01-16 22:45 ` Jeff Garzik
2007-01-16 23:11 ` James Bottomley
2007-01-16 23:17 ` Brian King
2007-01-16 23:30 ` James Bottomley
2007-01-16 23:33 ` Brian King
2007-01-17 2:34 ` [PATCH] libata: initialize qc->dma_dir to DMA_NONE Tejun Heo
2007-01-17 3:43 ` Brian King
2007-01-17 3:59 ` Jeff Garzik
2007-01-17 14:37 ` Brian King
2007-01-17 18:35 ` Brian King
2007-01-17 15:19 ` James Bottomley
2007-01-17 15:49 ` Tejun Heo [this message]
2007-01-17 16:07 ` James Bottomley
2007-01-20 0:19 ` Jeff Garzik
2007-01-16 23:28 ` ipr SATA problems in 2.6.20 Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AE4589.4070309@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@SteelEye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=brking@linux.vnet.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).