From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_uli: ignore SIMPLEX
Date: Fri, 19 Jan 2007 19:17:02 -0500 [thread overview]
Message-ID: <45B15F7E.2080807@pobox.com> (raw)
In-Reply-To: <20070116055551.GN10987@htj.dyndns.org>
Tejun Heo wrote:
> Some uli controllers have stuck SIMPLEX bit which can't be cleared
> with ata_pci_clear_simplex(), but the controller is capable of doing
> DMAs on both channels simultaneously. Ignore it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/ata/sata_uli.c b/drivers/ata/sata_uli.c
> index 5c603ca..62b9269 100644
> --- a/drivers/ata/sata_uli.c
> +++ b/drivers/ata/sata_uli.c
> @@ -226,6 +226,13 @@ static int uli_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
>
> probe_ent->private_data = hpriv;
>
> + /* these chips have stuck dummy simplex bit, ignore it */
> + if (probe_ent->_host_flags & ATA_HOST_SIMPLEX) {
> + dev_printk(KERN_INFO, &pdev->dev,
> + "BMDMA simplex set, ignored\n");
> + probe_ent->_host_flags &= ~ATA_HOST_SIMPLEX;
> + }
This is going to be the common case going forward. Please create an
'ignore simplex bit' flag, and set it in sata_uli
Jeff
next prev parent reply other threads:[~2007-01-20 0:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 5:55 [PATCH] sata_uli: ignore SIMPLEX Tejun Heo
2007-01-16 11:46 ` Alan
2007-01-20 0:17 ` Jeff Garzik [this message]
2007-01-20 3:41 ` Tejun Heo
2007-01-20 4:05 ` Jeff Garzik
2007-01-22 11:30 ` Alan
2007-01-25 10:40 ` [PATCH] libata: implement ATA_FLAG_IGN_SIMPLEX and use it in sata_uli Tejun Heo
2007-01-25 22:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B15F7E.2080807@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).