* [PATCH] ahci: make ULi M5288 ignore interface fatal error bit
@ 2007-01-23 6:13 Tejun Heo
2007-01-24 6:57 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-01-23 6:13 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
As with JMicron controllers, ULi M5288 sets interface fatal error bit
on device error including ATAPI CC. This makes libata hardreset the
port on ATAPI CC thus making it impossible to use. Ignore interface
fatal error bit on ULi M5288. This fixes bugzilla bug #7837.
Signed-off-by: Tejun Heo <htejun@gmail.com>
---
Jeff, this is a regression. Please commit to both #upstream and
#upstream-fixes. Thanks.
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 5998f74..4fb41a1 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -361,7 +361,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
{ PCI_VDEVICE(INTEL, 0x27c1), board_ahci }, /* ICH7 */
{ PCI_VDEVICE(INTEL, 0x27c5), board_ahci }, /* ICH7M */
{ PCI_VDEVICE(INTEL, 0x27c3), board_ahci }, /* ICH7R */
- { PCI_VDEVICE(AL, 0x5288), board_ahci }, /* ULi M5288 */
+ { PCI_VDEVICE(AL, 0x5288), board_ahci_ign_iferr }, /* ULi M5288 */
{ PCI_VDEVICE(INTEL, 0x2681), board_ahci }, /* ESB2 */
{ PCI_VDEVICE(INTEL, 0x2682), board_ahci }, /* ESB2 */
{ PCI_VDEVICE(INTEL, 0x2683), board_ahci }, /* ESB2 */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ahci: make ULi M5288 ignore interface fatal error bit
2007-01-23 6:13 [PATCH] ahci: make ULi M5288 ignore interface fatal error bit Tejun Heo
@ 2007-01-24 6:57 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-01-24 6:57 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> As with JMicron controllers, ULi M5288 sets interface fatal error bit
> on device error including ATAPI CC. This makes libata hardreset the
> port on ATAPI CC thus making it impossible to use. Ignore interface
> fatal error bit on ULi M5288. This fixes bugzilla bug #7837.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Jeff, this is a regression. Please commit to both #upstream and
> #upstream-fixes. Thanks.
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-24 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-23 6:13 [PATCH] ahci: make ULi M5288 ignore interface fatal error bit Tejun Heo
2007-01-24 6:57 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).