* [PATCH 1/4] libata.h: add another IRQ calls
@ 2007-01-16 10:46 Akira Iguchi
0 siblings, 0 replies; 3+ messages in thread
From: Akira Iguchi @ 2007-01-16 10:46 UTC (permalink / raw)
To: linux-ide
Cc: linuxppc-dev, kou.ishizaki, benh, arnd, paulus, linas, jeff, alan
Two IRQ calls are added in ata_port_operations.
- irq_on() is used to enable interrupts.
- irq_ack() is used to acknowledge a device interrupt.
And there are additional function declarations which are
used in pata_scc.c.
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
---
--- linux-2.6.20-rc4/include/linux/libata.h.orig 2007-01-17 01:46:12.000000000 +0900
+++ linux-2.6.20-rc4/include/linux/libata.h 2007-01-17 02:14:57.000000000 +0900
@@ -638,6 +638,8 @@ struct ata_port_operations {
irq_handler_t irq_handler;
void (*irq_clear) (struct ata_port *);
+ u8 (*irq_on) (struct ata_port *);
+ u8 (*irq_ack) (struct ata_port *ap, unsigned int chk_drq);
u32 (*scr_read) (struct ata_port *ap, unsigned int sc_reg);
void (*scr_write) (struct ata_port *ap, unsigned int sc_reg,
@@ -761,6 +763,9 @@ extern void ata_port_queue_task(struct a
extern u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
unsigned long interval_msec,
unsigned long timeout_msec);
+unsigned int ata_dev_try_classify(struct ata_port *, unsigned int, u8 *);
+struct ata_probe_ent *ata_probe_ent_alloc(struct device *,
+ const struct ata_port_info *);
/*
* Default driver ops implementations
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/4] libata.h: add another IRQ calls
@ 2007-01-16 10:46 Akira Iguchi
0 siblings, 0 replies; 3+ messages in thread
From: Akira Iguchi @ 2007-01-16 10:46 UTC (permalink / raw)
To: linux-ide; +Cc: jeff, arnd, linuxppc-dev, paulus, alan
Two IRQ calls are added in ata_port_operations.
- irq_on() is used to enable interrupts.
- irq_ack() is used to acknowledge a device interrupt.
And there are additional function declarations which are
used in pata_scc.c.
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
---
--- linux-2.6.20-rc4/include/linux/libata.h.orig 2007-01-17 01:46:12.000000000 +0900
+++ linux-2.6.20-rc4/include/linux/libata.h 2007-01-17 02:14:57.000000000 +0900
@@ -638,6 +638,8 @@ struct ata_port_operations {
irq_handler_t irq_handler;
void (*irq_clear) (struct ata_port *);
+ u8 (*irq_on) (struct ata_port *);
+ u8 (*irq_ack) (struct ata_port *ap, unsigned int chk_drq);
u32 (*scr_read) (struct ata_port *ap, unsigned int sc_reg);
void (*scr_write) (struct ata_port *ap, unsigned int sc_reg,
@@ -761,6 +763,9 @@ extern void ata_port_queue_task(struct a
extern u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
unsigned long interval_msec,
unsigned long timeout_msec);
+unsigned int ata_dev_try_classify(struct ata_port *, unsigned int, u8 *);
+struct ata_probe_ent *ata_probe_ent_alloc(struct device *,
+ const struct ata_port_info *);
/*
* Default driver ops implementations
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] libata.h: add another IRQ calls
[not found] <200701161045.l0GAjwJ0029209@toshiba.co.jp>
@ 2007-01-25 1:10 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-01-25 1:10 UTC (permalink / raw)
To: Akira Iguchi
Cc: linux-ide, linuxppc-dev, kou.ishizaki, benh, arnd, paulus, linas,
alan
Akira Iguchi wrote:
> Two IRQ calls are added in ata_port_operations.
> - irq_on() is used to enable interrupts.
> - irq_ack() is used to acknowledge a device interrupt.
>
> And there are additional function declarations which are
> used in pata_scc.c.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
After this round of comments, please resend the entire patchset, so that
I have everything straight.
> @@ -761,6 +763,9 @@ extern void ata_port_queue_task(struct a
> extern u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
> unsigned long interval_msec,
> unsigned long timeout_msec);
> +unsigned int ata_dev_try_classify(struct ata_port *, unsigned int, u8 *);
> +struct ata_probe_ent *ata_probe_ent_alloc(struct device *,
> + const struct ata_port_info *);
>
To properly export these functions, (a) remove their declarations from
drivers/ata/libata.h and (b) add EXPORT_SYMBOL_GPL() declarations.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-01-25 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200701161045.l0GAjwJ0029209@toshiba.co.jp>
2007-01-25 1:10 ` [PATCH 1/4] libata.h: add another IRQ calls Jeff Garzik
2007-01-16 10:46 Akira Iguchi
-- strict thread matches above, loose matches on Subject: below --
2007-01-16 10:46 Akira Iguchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).