From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] ahci: improve and limit spurious interrupt messages, take#2
Date: Wed, 24 Jan 2007 20:24:42 -0500 [thread overview]
Message-ID: <45B806DA.1050107@pobox.com> (raw)
In-Reply-To: <20070116065239.GO10987@htj.dyndns.org>
Tejun Heo wrote:
> - /* ignore interim PIO setup fis interrupts */
> - if (ata_tag_valid(ap->active_tag) && (status & PORT_IRQ_PIOS_FIS))
> - return;
> + if ((status & PORT_IRQ_D2H_REG_FIS) &&
> + !(pp->seen_status & PORT_IRQ_D2H_REG_FIS)) {
> + ata_port_printk(ap, KERN_INFO, "D2H reg with I during NCQ, "
> + "this message won't be printed again\n");
> + pp->seen_status |= PORT_IRQ_D2H_REG_FIS;
> + } else if ((status & PORT_IRQ_DMAS_FIS) &&
> + !(pp->seen_status & PORT_IRQ_DMAS_FIS)) {
> + ata_port_printk(ap, KERN_INFO, "DMAS FIS during NCQ, "
> + "this message won't be printed again\n");
> + pp->seen_status |= PORT_IRQ_DMAS_FIS;
> + } else if (status & PORT_IRQ_SDB_FIS && pp->spurious_sdb_cnt < 10) {
> + /* SDB FIS containing spurious completions might be
> + * dangerous, we need to know more about them. Print
> + * more of it.
> + */
> + const u32 *f = pp->rx_fis + RX_FIS_SDB;
This if/else/else tree does not take into account the possiblity that
more than one bit may be set.
Jeff
next prev parent reply other threads:[~2007-01-25 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 9:01 [PATCH] ahci: improve and limit spurious interrupt messages Tejun Heo
2007-01-16 6:52 ` [PATCH] ahci: improve and limit spurious interrupt messages, take#2 Tejun Heo
2007-01-25 1:24 ` Jeff Garzik [this message]
2007-01-25 7:55 ` Tejun Heo
2007-01-25 10:16 ` ahci: improve and limit spurious interrupt messages, take#3 Tejun Heo
2007-01-25 22:24 ` Jeff Garzik
2007-01-26 2:04 ` Jeff Garzik
2007-01-26 5:47 ` [PATCH] ahci: fix endianness in spurious interrupt message Tejun Heo
2007-01-26 22:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B806DA.1050107@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).