From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: share PIO limits among devices sharing a channel
Date: Thu, 25 Jan 2007 22:30:07 +0900 [thread overview]
Message-ID: <45B8B0DF.4080602@gmail.com> (raw)
In-Reply-To: <45B8A63F.8060305@pobox.com>
Jeff Garzik wrote:
> Alan wrote:
>> On Thu, 25 Jan 2007 20:29:47 +0900
>> Tejun Heo <htejun@gmail.com> wrote:
>>
>>> PIO xfermask limits should be shared by all devices on the same
>>> channel to avoid violating device selection timing. libata used to
>>
>> NAK, this is totally wrong
Eek.. You actually said this is/was documented and relied upon all over.
http://thread.gmane.org/gmane.linux.ide/13184/focus=14486
(searching mailboxes more...) Oh, and the dropping of common PIO mode
selection was agreed upon by Jeff and Alan.
One way or the other, this only affects PATA devices and as long as all
PATA LLDs guarantee that selection timing isn't violated, this can go.
I thought PATA drivers still relied on this common denominator PIO mode
configuration. I think it's Alan's call.
> I'm curious what the motivation of this patch was?
Hope my intentions are explained.
Thanks.
--
tejun
next prev parent reply other threads:[~2007-01-25 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 11:29 [PATCH] libata: share PIO limits among devices sharing a channel Tejun Heo
2007-01-25 12:30 ` Alan
2007-01-25 12:44 ` Jeff Garzik
2007-01-25 13:30 ` Tejun Heo [this message]
2007-01-25 13:50 ` Alan
2007-01-25 14:36 ` Tejun Heo
2007-01-25 14:25 ` Sergei Shtylyov
2007-01-25 14:51 ` Alan
2007-01-25 14:54 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B8B0DF.4080602@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).