From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement ATA_FLAG_IGN_SIMPLEX and use it in sata_uli
Date: Thu, 25 Jan 2007 17:26:37 -0500 [thread overview]
Message-ID: <45B92E9D.9010507@pobox.com> (raw)
In-Reply-To: <20070125104005.GB8606@htj.dyndns.org>
Tejun Heo wrote:
> Some uli controllers have stuck SIMPLEX bit which can't be cleared
> with ata_pci_clear_simplex(), but the controller is capable of doing
> DMAs on both channels simultaneously. Implement ATA_FLAG_IGN_SIMPLEX
> which makes libata ignore the simplex bit and use it in sata_uli.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Jeff, implemented as ATA_FLAG_* as requested. The patch is against
> #upstream-fixes and should probably included in 2.6.20. Thanks.
>
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index 623cec9..71e6ddd 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
> @@ -870,7 +870,8 @@ ata_pci_init_native_mode(struct pci_dev *pdev, struct ata_port_info **port, int
> pci_resource_start(pdev, 1) | ATA_PCI_CTL_OFS;
> bmdma = pci_resource_start(pdev, 4);
> if (bmdma) {
> - if (inb(bmdma + 2) & 0x80)
> + if (!(port[p]->flags & ATA_FLAG_IGN_SIMPLEX) &&
> + inb(bmdma + 2) & 0x80)
> probe_ent->_host_flags |= ATA_HOST_SIMPLEX;
> probe_ent->port[p].bmdma_addr = bmdma;
> }
> @@ -886,7 +887,8 @@ ata_pci_init_native_mode(struct pci_dev *pdev, struct ata_port_info **port, int
> bmdma = pci_resource_start(pdev, 4);
> if (bmdma) {
> bmdma += 8;
> - if(inb(bmdma + 2) & 0x80)
> + if (!(port[p]->flags & ATA_FLAG_IGN_SIMPLEX) &&
> + inb(bmdma + 2) & 0x80)
> probe_ent->_host_flags |= ATA_HOST_SIMPLEX;
> probe_ent->port[p].bmdma_addr = bmdma;
> }
applied to #upstream-fixes, after adding some additional parens for
readability
prev parent reply other threads:[~2007-01-25 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 5:55 [PATCH] sata_uli: ignore SIMPLEX Tejun Heo
2007-01-16 11:46 ` Alan
2007-01-20 0:17 ` Jeff Garzik
2007-01-20 3:41 ` Tejun Heo
2007-01-20 4:05 ` Jeff Garzik
2007-01-22 11:30 ` Alan
2007-01-25 10:40 ` [PATCH] libata: implement ATA_FLAG_IGN_SIMPLEX and use it in sata_uli Tejun Heo
2007-01-25 22:26 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B92E9D.9010507@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).