[PATCH] ahci: use 0x80 as wait stat value instead of 0xff

[PATCH] ahci: use 0x80 as wait stat value instead of 0xff

[Tejun Heo]

Before hardreset, ahci initialized stat part of received FIS area to
0xff to wait for the first D2H Reg FIS which would change the value to
device ready state.  This used to work but now libata considers status
value of 0xff as device not present making this wait prone to failure.

This patch makes ahci use 0x80 for the wait stat value instead of
0xff to fix the above problem.

Signed-off-by: Tejun Heo <htejun@gmail.com>

 drivers/ata/ahci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/ata/ahci.c
===================================================================
--- work.orig/drivers/ata/ahci.c
+++ work/drivers/ata/ahci.c
@@ -915,7 +915,7 @@ static int ahci_hardreset(struct ata_por
 
 	/* clear D2H reception area to properly wait for D2H FIS */
 	ata_tf_init(ap->device, &tf);
-	tf.command = 0xff;
+	tf.command = 0x80;
 	ata_tf_to_fis(&tf, d2h_fis, 0);
 
 	rc = sata_std_hardreset(ap, class);

Re: [PATCH] ahci: use 0x80 as wait stat value instead of 0xff

[Jeff Garzik]

Tejun Heo wrote:
> Before hardreset, ahci initialized stat part of received FIS area to
> 0xff to wait for the first D2H Reg FIS which would change the value to
> device ready state.  This used to work but now libata considers status
> value of 0xff as device not present making this wait prone to failure.
> 
> This patch makes ahci use 0x80 for the wait stat value instead of
> 0xff to fix the above problem.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied to #upstream-fixes

Re: [PATCH] ahci: use 0x80 as wait stat value instead of 0xff

[Jeff Garzik]

Tejun Heo wrote:
> Before hardreset, ahci initialized stat part of received FIS area to
> 0xff to wait for the first D2H Reg FIS which would change the value to
> device ready state.  This used to work but now libata considers status
> value of 0xff as device not present making this wait prone to failure.
> 
> This patch makes ahci use 0x80 for the wait stat value instead of
> 0xff to fix the above problem.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
>  drivers/ata/ahci.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

For the future, please make sure to include the "---" terminator prior 
to the diffstat, otherwise it will get copied into the kernel changelog.

	Jeff

Re: [PATCH] ahci: use 0x80 as wait stat value instead of 0xff

[Tejun Heo]

Jeff Garzik wrote:
> Tejun Heo wrote:
>> Before hardreset, ahci initialized stat part of received FIS area to
>> 0xff to wait for the first D2H Reg FIS which would change the value to
>> device ready state.  This used to work but now libata considers status
>> value of 0xff as device not present making this wait prone to failure.
>>
>> This patch makes ahci use 0x80 for the wait stat value instead of
>> 0xff to fix the above problem.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>>
>>  drivers/ata/ahci.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> For the future, please make sure to include the "---" terminator prior
> to the diffstat, otherwise it will get copied into the kernel changelog.

Argh... sure.  My mistake.  Sorry.

-- 
tejun